[Home]

Summary:DAHLIN-00117: oops after removing an echocan module that is in use
Reporter:Tzafrir Cohen (tzafrir)Labels:
Date Opened:2009-06-15 03:57:06Date Closed:2009-06-28 23:47:28
Priority:CriticalRegression?No
Status:Closed/CompleteComponents:General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:1. Start a system as usual (with Asterisk and with channels that have echo cancelers).

2. rmmod dahdi_echocan_<whatever>

3. cat /proc/dahdi/*

4. oops

The module is used by other modules. And yet we don't keep proper reference counting.

****** ADDITIONAL INFORMATION ******

[58221.455770] BUG: unable to handle kernel paging request at fff2baef
[58221.455913] IP: [<c01e1b36>] strnlen+0x6/0x18
[58221.456014] *pde = 00007067 *pte = 00000000
[58221.456022] Oops: 0000 [#1] SMP
[58221.456026] Modules linked in: dahdi_echocan_oslec xpp_usb xpd_bri xpd_pri xpd_fxo xpd_fxs xpp dahdi_echocan_mg2 dahdi echo battery ppdev lp speedstep_lib cpufreq_conservative c
pufreq_userspace cpufreq_ondemand cpufreq_powersave cpufreq_stats freq_table ipv6 loop snd_intel8x0 parport_pc parport snd_ac97_codec ac97_bus snd_pcm snd_seq snd_timer snd_seq_dev
ice irtty_sir snd sir_dev irda crc_ccitt soundcore snd_page_alloc pcspkr i2c_i801 i2c_core rng_core shpchp iTCO_wdt pci_hotplug button intel_agp agpgart evdev ext3 jbd mbcache ide_
cd_mod cdrom ide_disk ata_generic libata scsi_mod dock ide_pci_generic 8139cp floppy 8139too mii piix ide_core ehci_hcd uhci_hcd usbcore thermal processor fan thermal_sys [last unl
oaded: dahdi_echocan_oslec]
[58221.456026]
[58221.456026] Pid: 30488, comm: lsdahdi Not tainted (2.6.26-2-686 #1)
[58221.456026] EIP: 0060:[<c01e1b36>] EFLAGS: 00010297 CPU: 0
[58221.456026] EIP is at strnlen+0x6/0x18
[58221.456026] EAX: fff2baef EBX: c5987067 ECX: fff2baef EDX: fffffffe
[58221.456026] ESI: fff2baef EDI: ffffffff EBP: c5987c00 ESP: c3e79db4
[58221.456026]  DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
[58221.456026] Process lsdahdi (pid: 30488, ti=c3e78000 task=c1679660 task.ti=c3e78000)
[58221.456026] Stack: c01e0f94 c3e79f08 c5987067 c3e79f08 ffffffff c01e1269 ffffffff ffffffff
[58221.456026]        00000000 00000ba0 c5987060 00987057 c5987c00 c5987c00 00000000 ffffffff
[58221.456026]        d03a94a8 d03a949f 00000000 c888f63c ccb855e8 c017a5a4 c3e79e6c c3e79e58
[58221.456026] Call Trace:
[58221.456026]  [<c01e0f94>] string+0x27/0x6f
[58221.456026]  [<c01e1269>] vsnprintf+0x28d/0x452
[58221.456026]  [<c017a5a4>] do_lookup+0x53/0x153
[58221.456026]  [<c0182666>] dput+0x15/0xbb
[58221.456026]  [<c017c4d6>] __link_path_walk+0xa01/0xb0d
[58221.456026]  [<d053fede>] xframe_queue_adjust+0x1ef/0x1f9 [xpp]
[58221.456026]  [<c0186a74>] mntput_no_expire+0x13/0xd9
[58221.456026]  [<c015accf>] get_page_from_freelist+0xc1/0x3e3
[58221.456026]  [<c01e14a4>] snprintf+0x1c/0x1f
[58221.456026]  [<d03a7aea>] dahdi_proc_read+0x6c6/0x780 [dahdi]
[58221.456026]  [<d03a7424>] dahdi_proc_read+0x0/0x780 [dahdi]
[58221.456026]  [<c01a4a61>] proc_file_read+0x0/0x1ff
[58221.456026]  [<c01a4b37>] proc_file_read+0xd6/0x1ff
[58221.456026]  [<c01a4a61>] proc_file_read+0x0/0x1ff
[58221.456026]  [<c01a1362>] proc_reg_read+0x58/0x6b
[58221.456026]  [<c01a130a>] proc_reg_read+0x0/0x6b
[58221.456026]  [<c0174a52>] vfs_read+0x81/0x11e
[58221.456026]  [<c0174ea3>] sys_read+0x3c/0x63
[58221.456026]  [<c0103853>] sysenter_past_esp+0x78/0xb1
[58221.456026]  =======================
[58221.456026] Code: c9 74 0c f2 ae 74 05 bf 01 00 00 00 4f 89 fa 5f 89 d0 c3 85 c9 57 89 c7 89 d0 74 05 f2 ae 75 01 4f 89 f8 5f c3 89 c1 89 c8 eb 06 <80> 38 00 74 07 40 4a 83 fa ff 75 f4 29 c8 c3 90 90 90 57 83 c9
[58221.456026] EIP: [<c01e1b36>] strnlen+0x6/0x18 SS:ESP 0068:c3e79db4
[58221.456026] ---[ end trace 50c51324b8305f34 ]---
Comments:By: Tzafrir Cohen (tzafrir) 2009-06-15 04:03:17

Hmm... forgot about DAHLIN-40.
By: Digium Subversion (svnbot) 2009-06-28 23:47:27

Repository: dahdi
Revision: 6785

U   linux/trunk/drivers/dahdi/dahdi-base.c

------------------------------------------------------------------------
r6785 | sruffell | 2009-06-28 23:47:26 -0500 (Sun, 28 Jun 2009) | 5 lines

echocan: Properly keep the reference counts for the echocan modules.

(closes issue DAHLIN-40)
(closes issue DAHLIN-117)
Reported by: sruffell, tzafrir
------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=6785