| Summary: | DAHLIN-00105: [patch] dahdi_dialparams fields are inconsistent | ||
| Reporter: | Dmitry Andrianov (dimas) | Labels: | |
| Date Opened: | 2009-05-21 13:54:23 | Date Closed: | 2012-09-10 08:03:39 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) v1-15173.patch | |
| Description: | DISCLAIMER The patch is "theoreticsl" - I just checked it compiles but I can not even test it because I'm not using DAHDI but currently running on Zaptel instead. While I believe the patch is right, I'm not saying it is the exact changes that needs to be applied. It is more like an illustration to a DAHDI developer with a proposed fix to the problem I discovered. END OF DISCLAIMER I found that fields of global_dialparams like dtmf_tonelen may be a bit inconsistent - these are initialized with DEFAULT_DTMF_LENGTH which is length in samples but when userspace uses DAHDI_SET_DIALPARAMS ioctl, to set the desired value, the same field receives duration in milliseconds. The ioctl_load_zone expects these fields to be length in samples thougt... The patch tries to remove this inconsistency by making sure that these tonelen fields are always in milliseconds. Again, needs to be revied by DAHDI guy. | ||
| Comments: | By: Dmitry Andrianov (dimas) 2010-01-20 16:27:11.000-0600 I'm curious if someone is going to take a look eventually :) By: Shaun Ruffell (sruffell) 2012-09-10 08:03:39.865-0500 Dmitry: Sorry this say unlooked at for so long. However, I don't think this applies since [r9616 "dahdi: Move the default tone lengths into include/dahdi/dahdi_config.h"|http://svnview.digium.com/svn/dahdi?view=revision&revision=9616]. If I'm wrong please reopen. Again, my apologies for the silence on this one. | ||