[Home]

Summary:DAHLIN-00102: [patch] Specify default signaling for FXS and FXO modules
Reporter:Kinsey Moore (opticron)Labels:
Date Opened:2009-05-11 13:36:32Date Closed:2012-09-10 08:13:00
Priority:MajorRegression?No
Status:Closed/CompleteComponents:wctdm24xxp
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) defsig.diff
Description:Currently, when FXS and FXO modules are loaded, they are not assigned a signaling, and so none is shown in the /proc/dahdi interface.  With this small patch which applies cleanly against trunk and 2.1.0.4 (and I assume the 2.2.0 RCs as well), the kewlstart signaling variant is selected as a default.  This allows configuration generators, such as dahdi_genconf, to discover the type and required signaling of each channel without resorting to complicated techniques such as parsing dmesg output or probing with dahdi_cfg.  The only other sane default would be the loopstart variant, but it seems to me that kewlstart is pre prevalent.  If I'm wrong about that, the patch can easily be changed to reflect that.
Comments:By: Kinsey Moore (opticron) 2009-05-11 13:38:08

I forgot to mention that this change only applies to Digium's cards and others that use the wctdm24xxp driver.


By: Kinsey Moore (opticron) 2009-05-11 13:54:57

If it isn't worth creating a second issue in the tracker, I can submit a similar patch for wctdm.c in this issue.
By: Leif Madsen (lmadsen) 2009-09-21 10:38:03

You can probably just put the other patch here along with this issue, and perhaps update the topic to be more general (or mention both modules, etc...)
By: Shaun Ruffell (sruffell) 2012-09-10 08:12:25.114-0500

Kinsey: In an effort to close out some of the old issues each day, I'm going to close this.  a) As written it might prevent the chanconfig callback in the board driver from writing if dahdi_cfg doesn't believe the configuration needs updating and b) The move is for this information to be determined via sysfs. I believe what will happen is that the signalling capabilities will be exported there.

If you disagree, please feel free to reopen.