| Summary: | DAHLIN-00065: [patch] OSLEC ec integration is not working properly | ||
| Reporter: | Marco Signorini (marcotasto) | Labels: | |
| Date Opened: | 2008-12-09 04:17:34.000-0600 | Date Closed: | 2008-12-11 14:51:13.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | dahdi (the module) |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) dahdi_echocan_oslec.patch | |
| Description: | After installing the OSLEC ec following the instruction found on the README.txt file under dahdi-linux svn trunk revision 5452 and configured system.conf to force oslec as echo canceler for one channel, I can hear a lot of echo in incoming and outgoing calls. OSLEC seems correctly compiled, linked, installed and modprobed but is not working properly. ****** ADDITIONAL INFORMATION ****** After a first investigation I've found the problem and I can submit patches to solve it. There are two issues in the oslec integration for dahdi (dahdi_echocan_oslec.c). 1. oslec ec is not properly initialized with default parameters by the oslec_create function. 2. the echo_can_update function is calculating echo suppression only on the first sample of the dahdi buffer chunk. The result of the calculation is then lost. | ||
| Comments: | By: Digium Subversion (svnbot) 2008-12-11 14:51:13.000-0600 Repository: dahdi Revision: 5503 U linux/trunk/drivers/dahdi/dahdi_echocan_oslec.c ------------------------------------------------------------------------ r5503 | tzafrir | 2008-12-11 14:51:12 -0600 (Thu, 11 Dec 2008) | 7 lines Send all samples to OSLEC, rather than just the first. (closes issue DAHLIN-65) Reported by: marcotasto Patches: dahdi_echocan_oslec.patch uploaded by marcotasto (license 635) ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=5503 | ||