| Summary: | DAHLIN-00053: Ignored return value of down_interruptible() | ||
| Reporter: | Matthias Urlichs (smurfix) | Labels: | |
| Date Opened: | 2008-10-20 00:27:14 | Date Closed: | 2008-12-19 11:26:24.000-0600 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | dahdi (the module) |
| Versions: | 2.0.0 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | This will cause severe consistency problems if somebody ever presses ^C at the wrong time. /tmp/mis/usr_src/modules/dahdi/drivers/dahdi/wctdm24xxp/GpakCust.c:411: warning: ignoring return value of ‘down_interruptible’, declared with attribute warn_unused_result /tmp/mis/usr_src/modules/dahdi/drivers/dahdi/wcte12xp/vpmadt032.c:1067: warning: ignoring return value of ‘down_interruptible’, declared with attribute warn_unused_result | ||
| Comments: | By: Leif Madsen (lmadsen) 2008-10-21 09:22:23 I'm assigning this issue to sruffell in the hopes this may be a simple issue to move forward. Please feel free to reassign if this is not the case. Thanks! By: Digium Subversion (svnbot) 2008-11-05 13:59:53.000-0600 Repository: dahdi Revision: 5236 U linux/trunk/drivers/dahdi/wctdm24xxp/GpakCust.c U linux/trunk/drivers/dahdi/wcte12xp/vpmadt032.c ------------------------------------------------------------------------ r5236 | sruffell | 2008-11-05 13:59:53 -0600 (Wed, 05 Nov 2008) | 11 lines Check the return value of the down_interruptible call in order to quiet a warning. This semaphore does not protect any host data structures, but only accesses to the VPMADT032 module. The worse thing that could happen is that the internal state of the VPM module is corrupted, and then would only happen on module loading because otherwise access because that is the only time this function is called in the context of a user process. In this case, the module would need to be reloaded again anyway. (Closes issue DAHLIN-53) Reported by smurfix ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=5236 By: Digium Subversion (svnbot) 2008-12-19 11:26:24.000-0600 Repository: zaptel Revision: 4600 U branches/1.4/kernel/wctdm24xxp/GpakCust.c ------------------------------------------------------------------------ r4600 | sruffell | 2008-12-19 11:26:23 -0600 (Fri, 19 Dec 2008) | 2 lines Quiet a compilation warning. Related to issue ASTERISK-1319275 and ASTERISK-1364742. ------------------------------------------------------------------------ http://svn.digium.com/view/zaptel?view=rev&revision=4600 | ||