[Home]

Summary:DAHLIN-00042: wctc4xxp module parametr mode=g729 not work
Reporter:Martin Kuca (marvik)Labels:
Date Opened:2008-09-19 02:22:30Date Closed:2008-09-24 12:32:05
Priority:MinorRegression?No
Status:Closed/CompleteComponents:dahdi_transcode
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 13518.diff
Description:Module parameter mode=g729 do not work, 120 g729 channel is not available.

****** ADDITIONAL INFORMATION ******

revision 4965
Comments:By: Brandon Kruse (bkruse) 2008-09-19 15:37:56

You say it is revision 4965 but 4539 is the latest revision?

could you paste your svn info of the zaptel directory?

Thanks,

-bk
By: Brandon Kruse (bkruse) 2008-09-19 15:42:35

Also, can you insmod the module with mode=g729 then paste the last part of dmesg?

I think I see it...

-bk
By: Brandon Kruse (bkruse) 2008-09-19 15:55:27

Try that patch please, I am not sure if this is the only problem, or why it was removed, but this appears to be the problem.

-bk
By: Martin Kuca (marvik) 2008-09-19 15:55:43

[root@linux pom]# svn checkout http://svn.digium.com/svn/dahdi/linux/trunk dahdi

Fetching external item into 'dahdi/drivers/dahdi/oct612x'
Checked out external at revision 36.

Checked out revision 4968.


I think there is no parameter mode in base.c file

[root@linux wctc4xxp]# tail base.c

module_param(debug, int, S_IRUGO | S_IWUSR);
MODULE_DESCRIPTION("Wildcard TC400P+TC400M Driver");
MODULE_AUTHOR("Digium Incorporated <support@digium.com>");
MODULE_LICENSE("GPL");

module_init(wctc4xxp_init);
module_exit(wctc4xxp_cleanup);
By: Brandon Kruse (bkruse) 2008-09-19 15:59:54

Oh ok, it is dahdi, my apologies.

Of course, can you apply that patch manually? (it is very trivial, only one line) or do you want me to make another diff for you?

Thanks,

-bk
By: Brandon Kruse (bkruse) 2008-09-19 16:07:50

There is no module_param, but, if you look in the code, the option "mode" does exist as a character pointer, and it checked on init, so try that patch.

-bk
By: Martin Kuca (marvik) 2008-09-24 08:52:35

i have downloaded latest trunk - option mode is there. Working ok.
By: Martin Kuca (marvik) 2008-09-24 09:04:55

please close this issue
By: Jason Parker (jparker) 2008-09-24 12:32:01

This issue was also being tracked internally as DAHDI-193.  It was fixed last night in svn trunk.