Summary:	DAHLIN-00034: [patch] ifup-hdlc does not install if using DESTDIR
Reporter:	Jeffrey C. Ollie (jcollie)	Labels:
Date Opened:	2008-09-05 11:15:27	Date Closed:	2008-09-11 10:38:19
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) 0001-Fix-install-of-ifup-hdlc-when-installing-into-an-alt.patch
Description:	ifup-hdlc won't install if you are using DESTDIR during the install because the Makefile is checking for /etc/sysconfig/network-scripts in the regular root directory and not inside the DESTDIR.  This is important when building a package for a distribution (like Fedora) where /etc/sysconfig/network-scripts probably won't exist in the minimal chroot that is used to build the package but $(DESTDIR)/etc/sysconfig/network-scripts gets created to install ifup-hdlc to. ****** ADDITIONAL INFORMATION ****** Patch attached.
Comments:	By: Jason Parker (jparker) 2008-09-10 14:22:58 I actually disagree with this. Looking at the lines just above there, you see it's doing the same check for /etc/init.d/.  I don't see why one should have to create every directory inside of the destination - it's my opinion that this should be done on the host (whether it be done in a chroot or otherwise). By: Digium Subversion (svnbot) 2008-09-11 10:35:29 Repository: dahdi Revision: 4893 U   tools/trunk/Makefile ------------------------------------------------------------------------ r4893 | qwell | 2008-09-11 10:35:28 -0500 (Thu, 11 Sep 2008) | 11 lines Fix installation of ifup-hdlc and init script when using DESTDIR. (Step 2 of cleanup) (closes issue DAHLIN-34) Reported by: jcollie Patches:      0001-Fix-install-of-ifup-hdlc-when-installing-into-an-alt.patch uploaded by jcollie (license 412) Tested by: qwell Note: Patch from DAHLIN-34 was extended to modify init script installation as well. ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=4893 By: Jason Parker (jparker) 2008-09-11 10:38:19 okay, so maybe I don't disagree after all. :)