[Home]

Summary:DAHLIN-00019: [patch] Fix segfaults in dahdi_cfg.c from error handling
Reporter:Brett Bryant (bbryant)Labels:
Date Opened:2008-07-09 13:06:40Date Closed:2008-08-01 16:18:11
Priority:CriticalRegression?No
Status:Closed/CompleteComponents:Utilities
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20080709__dahdi_cfg_fixes_2.diff
( 1) 20080709__dahdi_cfg_fixes.diff
Description:This patch fixes a couple of places where error() is assumed to stop execution. For example, it crashes if you don't have permission to read the config file.
This also fixes a bug in configuration parsing where a syntax error isn't detected for a keyword or value that only contains spaces.
Comments:By: Brett Bryant (bbryant) 2008-07-09 14:22:04

I've uploaded a second patch which fixes a crash in fclose I couldn't understand (just commented out the line), and an instance of strcpy that wasn't safe.
By: Tzafrir Cohen (tzafrir) 2008-07-12 08:41:26

What does the magic number 33 mean?
By: Brett Bryant (bbryant) 2008-07-14 16:27:11

tzafrir, any number below 33 is a whitespace or control character on the ascii table.
By: Digium Subversion (svnbot) 2008-08-01 16:18:09

Repository: dahdi
Revision: 4645

U   tools/trunk/dahdi_cfg.c

------------------------------------------------------------------------
r4645 | kpfleming | 2008-08-01 16:18:09 -0500 (Fri, 01 Aug 2008) | 7 lines

clean up error exit conditions and improve code in various places

(closes issue DAHLIN-19)
Reported by: bbryant
Patches:
     20080709__dahdi_cfg_fixes_2.diff uploaded by bbryant (license 36)

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=4645