Summary:	ASTERISK-30452: Test Suite: Fix regression causing all builds to fail
Reporter:	N A (InterLinked)	Labels:
Date Opened:	2023-03-05 07:25:46.000-0600	Date Closed:
Priority:	Major	Regression?
Status:	In Progress/In Progress	Components:	Tests/testsuite
Versions:	GIT	Frequency of Occurrence	Constant
Related Issues:
Environment:	Debian 11	Attachments:
Description:	Ever since commit c930bfec37118e37ff271bf381825408d2409fec, all my CI builds have been failing. It appears there is something invalid about tests/apps/tests.yaml on the last line (block sequence entries not allowed) that causes the parser to choke. The issue here is that the newline at the end of the file got removed, causing the parsing of that line to fail. This adds a newline to fix that. {noformat} Collecting https://github.com/asterisk/starpy/archive/refs/heads/1.1.zip (from -r ./extras.txt (line 1))  Downloading https://github.com/asterisk/starpy/archive/refs/heads/1.1.zip     - 70.1 kB 6.0 MB/s 0:00:00  Preparing metadata (setup.py): started  Preparing metadata (setup.py): finished with status 'done' Collecting https://github.com/asterisk/yappcap/archive/refs/heads/python3.zip (from -r ./extras.txt (line 2))  Downloading https://github.com/asterisk/yappcap/archive/refs/heads/python3.zip     - 354.0 kB 5.3 MB/s 0:00:00  Installing build dependencies: started  Installing build dependencies: finished with status 'done'  Getting requirements to build wheel: started  Getting requirements to build wheel: finished with status 'done'  Preparing metadata (pyproject.toml): started  Preparing metadata (pyproject.toml): finished with status 'done' Requirement already satisfied: Cython in ./.venv/lib/python3.9/site-packages (from yappcap==0.0.1->-r ./extras.txt (line 2)) (0.29.28) Traceback (most recent call last):  File "/usr/src/testsuite/runtests.py", line 1027, in <module>    sys.exit(main() or 0)  File "/usr/src/testsuite/runtests.py", line 952, in main    test_suite = TestSuite(options)  File "/usr/src/testsuite/runtests.py", line 492, in __init__    self.tests = self._parse_test_yaml("tests")  File "/usr/src/testsuite/runtests.py", line 536, in _parse_test_yaml    tests += self._parse_test_yaml(path)  File "/usr/src/testsuite/runtests.py", line 508, in _parse_test_yaml    config = load_yaml_config("%s/%s" % (test_dir, TESTS_CONFIG))  File "/usr/src/testsuite/runtests.py", line 794, in load_yaml_config    config = yaml.load(f, Loader=MyLoader)  File "/usr/src/testsuite/.venv/lib/python3.9/site-packages/yaml/__init__.py", line 81, in load    return loader.get_single_data()  File "/usr/src/testsuite/.venv/lib/python3.9/site-packages/yaml/constructor.py", line 49, in get_single_data    node = self.get_single_node()  File "yaml/_yaml.pyx", line 673, in yaml._yaml.CParser.get_single_node  File "yaml/_yaml.pyx", line 687, in yaml._yaml.CParser._compose_document  File "yaml/_yaml.pyx", line 731, in yaml._yaml.CParser._compose_node  File "yaml/_yaml.pyx", line 845, in yaml._yaml.CParser._compose_mapping_node  File "yaml/_yaml.pyx", line 729, in yaml._yaml.CParser._compose_node  File "yaml/_yaml.pyx", line 806, in yaml._yaml.CParser._compose_sequence_node  File "yaml/_yaml.pyx", line 731, in yaml._yaml.CParser._compose_node  File "yaml/_yaml.pyx", line 847, in yaml._yaml.CParser._compose_mapping_node  File "yaml/_yaml.pyx", line 860, in yaml._yaml.CParser._parse_next_event yaml.scanner.ScannerError: block sequence entries are not allowed in this context  in "tests/apps/tests.yaml", line 33, column 27 {noformat}
Comments:	By: Asterisk Team (asteriskteam) 2023-03-05 07:25:50.524-0600 The severity of this issue has been automatically downgraded from "Blocker" to "Major". The "Blocker" severity is reserved for issues which have been determined to block the next release of Asterisk. This severity can only be set by privileged users. If this issue is deemed to block the next release it will be updated accordingly during the triage process. By: Asterisk Team (asteriskteam) 2023-03-05 07:25:51.387-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/].