Summary:	ASTERISK-30359: Install Prereq Script Enhancements
Reporter:	Martin McCarthy (The_Blode)	Labels:	Bash, Contrib, sh
Date Opened:	2022-12-16 10:56:23.000-0600	Date Closed:	2023-04-10 13:04:46
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Contrib/General
Versions:	20.0.0	Frequency of Occurrence
Related Issues:
Environment:	Linux, BSD	Attachments:
Description:	======================================== Install Prereq Script Enhancements ======================================== Reporter: Martin McCarthy (The_Blode) Impacted Users: All users who install Asterisk. Affected Products: All Asterisk versions. Priority: Low / Lowest. Coding Time / Effort Estimate: 4 hours development / 4 hours QA testing. ======================================== Description ======================================== As you guys know, I'm getting into the world of Asterisk and file from #asterisk suggested that I use contrib/scripts/install_prereq but I noticed a few issues with it; - There was no debug in the terminal to tell me it was doing anything. - The help wasn't not very verbose. - Linux Mint was not supported. I've had a look at the script and proposed some changes; - Added a more verbose help menu. - Added error message for Mint users to inform them to submit a patch. - Reorganised and reformatted the source code to allow future patches to be submitted more easily. - Script verbosity has been increased. ======================================== End ========================================
Comments:	By: Asterisk Team (asteriskteam) 2022-12-16 10:56:26.606-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/]. By: Martin McCarthy (The_Blode) 2023-03-06 12:16:17.366-0600 Committed the code changes for the first round of feedback. remote:   https://gerrit.asterisk.org/c/asterisk/+/19939 install_prereq: Refactoring and enhancements. Thanks @file for helping me out. Cheers, Martin. By: Martin McCarthy (The_Blode) 2023-03-06 13:54:35.041-0600 ================================================== Code Review Feedback Updates from K ================================================== - Alphabetically sort this list ✅ 2023-03-06 18:55:12 - Remove unnecessary 'x'.  Straight string comparison is sufficient here. ✅ 2023-03-06 18:56:14 - All indenting needs to be tabs ✅ 2023-03-06 18:57:53 - I don't think it's necessary to date every function here.  This is not a library/api file.  - Same goes for all the others. ✅ 2023-03-06 19:02:49 - Same as above.  Please fix all of these. ✅ 2023-03-06 19:03:21 - Don't need to write a 'done' comment for every return unless there's something special going on. ✅ 2023-03-06 19:03:49 - The function name here is obvious.  Each comment block doesn't need to repeat the function name.  Same goes for all the others. ✅ 2023-03-06 19:05:48 - Fix coding style; if [ condition ]; then;   dostuff; fi ✅ 2023-03-06 19:09:30 - Fix for 80 column terminals. ✅ 2023-03-06 19:29:54 - Test results for all distros ⏳(pending) - In the comment blocks for each function.  Document the prerequisites for the function.  Describe what $PACKAGES_RH is supposed to be prior to the handle_rh() call. Same goes for all the other functions ⏳(pending) Remaining effort estimate: 2 weeks. By: Friendly Automation (friendly-automation) 2023-04-10 13:04:47.693-0500 Change 20053 merged by Friendly Automation: install_prereq: Add Linux Mint support. [https://gerrit.asterisk.org/c/asterisk/+/20053|https://gerrit.asterisk.org/c/asterisk/+/20053] By: Friendly Automation (friendly-automation) 2023-04-10 13:05:49.985-0500 Change 19974 merged by Friendly Automation: install_prereq: Add Linux Mint support. [https://gerrit.asterisk.org/c/asterisk/+/19974|https://gerrit.asterisk.org/c/asterisk/+/19974] By: Friendly Automation (friendly-automation) 2023-04-10 13:08:25.746-0500 Change 20052 merged by Friendly Automation: install_prereq: Add Linux Mint support. [https://gerrit.asterisk.org/c/asterisk/+/20052|https://gerrit.asterisk.org/c/asterisk/+/20052]