Summary:	ASTERISK-30224: Outbound proxy 'Route:' doubled in OPTIONS
Reporter:	Igor Goncharovsky (igorg)	Labels:
Date Opened:	2022-09-12 02:45:10	Date Closed:
Priority:	Major	Regression?
Status:	Open/New	Components:	Channels/chan_pjsip
Versions:	16.28.0	Frequency of Occurrence	Constant
Related Issues:
Environment:		Attachments:
Description:	In case of specifying outbound proxy in both endpoint and aor OPTION requset sent with both options used in Route: headers (first from endpoint and second from aor): Call-ID: 9fc278ae-f1d8-4fe7-94e5-7b9919253a75 CSeq: 55705 OPTIONS Route: <sip:demo.iqtek.ru:7000;lr> Route: <sip:78.24.220.116:7000;lr> Max-Forwards: 70 Content-Length:  0
Comments:	By: Asterisk Team (asteriskteam) 2022-09-12 02:45:16.302-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/]. By: George Joseph (gjoseph) 2022-09-12 06:52:37.583-0500 What do you think the proper behavior should be? Are you going to be submitting a Gerrit review to address the issue? By: Igor Goncharovsky (igorg) 2022-09-12 22:57:57.999-0500 As described at https://wiki.asterisk.org/wiki/display/AST/PJSIP+with+Proxies: - "aor: In order for Asterisk to send OPTIONS requests to the ITSP via the proxy, the outbound_proxy parameter needs to be added here as well.  All other aor parameters, including contact should be left just as though there were no proxy" - so I think aor outbound_proxy option should be independent from endpoint settings - "registration:  Same as aor.  The client and server URIs should remain as they were for the non-proxy situation and the outbound_proxy parameter should be added" - behaviour of outbound_proxy for aor and registration should be the same. Currently registaration outbound_proxy setting does not depend on endpoint setting. I am goint to look deeper and create patch, but maybe later (I do not work before with pjsip code). Currently I see that: - Endpoint proxy set in create_out_of_dialog_request() (using ast_sip_set_outbound_proxy()) - When OPTIONS sent proxy first time set in ast_sip_create_request() that calls create_out_of_dialog_request(). Secont time - by calling ast_sip_set_outbound_proxy() directly - Registrations in res_pjsip_outbound_registration.c do not use ast_sip_create_request() and duplicate code from ast_sip_set_outbound_proxy() to handle proxy addition. By: George Joseph (gjoseph) 2022-09-13 05:31:47.288-0500 Gotcha.  I'm going to assign this issue to you for now.  If you don't think you'll be able to work it, just let one of us know and we'll reassign it.