[Home]

Summary:ASTERISK-30076: app_stack: Incorrect exit location in predial handlers logged
Reporter:N A (InterLinked)Labels:
Date Opened:2022-05-22 07:29:52Date Closed:2022-11-02 10:48:54
Priority:TrivialRegression?
Status:Closed/CompleteComponents:Applications/app_stack
Versions:18.9.0 Frequency of
Occurrence		Constant
Related
Issues:
Environment:Attachments:
Description:Gosub prints out the wrong execution location to the CLI in predial handlers:

{noformat}
[2022-05-22 12:11:39] DEBUG[24614][C-00000052]: app_stack.c:578 expand_gosub_args: Gosub args:predial,s,1(2,) new_args:predial,s,1(2,)
[2022-05-22 12:11:39]     -- PJSIP/ATAxLB2-00000038 Internal Gosub(predial,s,1(2,)) start
[2022-05-22 12:11:39] DEBUG[24614][C-00000052]: app_stack.c:1070 gosub_run: PJSIP/ATAxLB2-00000038 Original location: orig-line-pjsip,s,1
[2022-05-22 12:11:39] DEBUG[24614][C-00000052]: app_stack.c:672 gosub_exec: Channel PJSIP/ATAxLB2-00000038 has no datastore, so we're allocating one.
[2022-05-22 12:11:39] DEBUG[24614][C-00000052]: app_stack.c:714 gosub_exec: Setting 'ARG1' to '2'
[2022-05-22 12:11:39] DEBUG[24614][C-00000052]: app_stack.c:714 gosub_exec: Setting 'ARG2' to ''
[2022-05-22 12:11:39] DEBUG[24614][C-00000052]: app_stack.c:1074 gosub_run: Gosub exited with status 0
[2022-05-22 12:11:39]     -- Executing [s@predial:1] PreDial("PJSIP/ATAxLB2-00000038", "c(2)") in new stack
[2022-05-22 12:11:39]     -- Executing [s@predial:2] Return("PJSIP/ATAxLB2-00000038", "") in new stack
[2022-05-22 12:11:39] DEBUG[24614][C-00000052]: app_stack.c:1132 gosub_run: Spawn extension (orig-line-pjsip,s,1) exited with -1 on 'PJSIP/ATAxLB2-00000038'
[2022-05-22 12:11:39]   == Spawn extension (orig-line-pjsip, s, 1) exited non-zero on 'PJSIP/ATAxLB2-00000038'
[2022-05-22 12:11:39]     -- PJSIP/ATAxLB2-00000038 Internal Gosub(predial,s,1(2,)) complete GOSUB_RETVAL=
[2022-05-22 12:11:39] DEBUG[24614][C-00000052]: app_stack.c:1158 gosub_run: PJSIP/ATAxLB2-00000038 Ending location: orig-line-pjsip,s,1
{noformat}

Here, orig-line-pjsip is the configured context for this PJSIP endpoint.

Execution never was in this context, since it's a predial handler. It should print out Spawn extension (predial,s,2) exited... instead, but it's printing out the channel's default context.

Doesn't affect anything per se but if a user is paying attention to the CLI, it can be quite confusing because it may seem as if the channel is doing something it shouldn't be.

Not fully sure what the most elegant fix here is, but it seems that we need to handle if we're doing a Gosub on a channel that didn't normally start in the PBX (like predial) and maybe NULL out the original context so that doesn't happen (though not sure of the implications of that).
Comments:By: Asterisk Team (asteriskteam) 2022-05-22 07:29:53.404-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur.

Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/].
By: Joshua C. Colp (jcolp) 2022-05-22 14:40:54.925-0500

You can not NULL out the original context. I'm fairly certain there are scenarios and situations where that is actually used.
By: Friendly Automation (friendly-automation) 2022-11-02 10:48:56.413-0500

Change 19402 merged by Friendly Automation:
app_stack: Print proper exit location for PBXless channels.

[https://gerrit.asterisk.org/c/asterisk/+/19402|https://gerrit.asterisk.org/c/asterisk/+/19402]
By: Friendly Automation (friendly-automation) 2022-11-02 10:50:32.185-0500

Change 19523 merged by Friendly Automation:
app_stack: Print proper exit location for PBXless channels.

[https://gerrit.asterisk.org/c/asterisk/+/19523|https://gerrit.asterisk.org/c/asterisk/+/19523]
By: Friendly Automation (friendly-automation) 2022-11-02 13:48:45.836-0500

Change 19531 merged by Friendly Automation:
app_stack: Print proper exit location for PBXless channels.

[https://gerrit.asterisk.org/c/asterisk/+/19531|https://gerrit.asterisk.org/c/asterisk/+/19531]