[Home]

Summary:ASTERISK-30052: add configuration setting to enable RTCP PLI, FIR and NACK independently from "webrtc" setting
Reporter:Università di Bologna - CESIA VoIP (cesia.voip@unibo.it)Labels:webrtc
Date Opened:2022-05-10 06:22:48Date Closed:
Priority:MinorRegression?
Status:In Progress/In ProgressComponents:Resources/res_pjsip_sdp_rtp
Versions:18.11.1 Frequency of
Occurrence
Related
Issues:
Environment:Sangoma FreePBX 14 and higher on Sangoma OS7Attachments:
Description:Asterisk's "webrtc" configuration setting in pjsip.conf enables several features required to correctly interface webrtc clients like:
+ dtls media
+ RTP MEDIA BUNDLE (RFC8843)
+ rtcp mux
+ avpf
+ ice
and particularly
+ RTP PLI, FIR, NACK, CCM (RFC5104 on AVPF)

In our application, webrtc is not exposed directly by Asterisk: for security reasons, we are deploying an external dedicated high-end commercial webrtc proxy that will be exposed on the internet.
To interoperate correctly on video streams our application needs RFC5104 enabled to support frame retransmission/resynchronization.
However, if we enable "webrtc" settings also the RFC8843 is automatically enabled: unfortunately, the webrtc proxy we are deploying does not support RFC8843 and does not work correctly.

We ask if you think would be possible to develop a little patch to read a new "use_rfc5104" setting which enables the required features (fir, nack, etc...) independently from the "webrtc" setting. In this way, we can enable FIR, NACK, etc... without the need to enable RTP MEDIA BUNDLE.
We tested positively this feature on our test environment and fully fix the issues.

What about if we make a merge request for this purpose?

Thank you in advance,

Camillo Toselli - Università di Bologna
Comments:By: Asterisk Team (asteriskteam) 2022-05-10 06:22:50.155-0500

The severity of this issue has been automatically downgraded from "Blocker" to "Major". The "Blocker" severity is reserved for issues which have been determined to block the next release of Asterisk. This severity can only be set by privileged users. If this issue is deemed to block the next release it will be updated accordingly during the triage process.
By: Asterisk Team (asteriskteam) 2022-05-10 06:22:50.805-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur.

Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/].
By: Joshua C. Colp (jcolp) 2022-05-10 06:25:05.028-0500

You're free to submit a Gerrit review for such a thing. Instructions are linked in the initial comment.
By: Asterisk Team (asteriskteam) 2022-05-24 12:00:01.132-0500

Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1].

[1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines
By: Università di Bologna - CESIA VoIP (cesia.voip@unibo.it) 2022-05-26 06:32:58.213-0500

Dear Joshua,

we have already developed the patch.
We are running test in various condition to verify that everything is working correctly.

Best Regards,

Camillo
By: Asterisk Team (asteriskteam) 2022-05-26 06:32:58.602-0500

This issue has been reopened as a result of your commenting on it as the reporter. It will be triaged once again as applicable.
By: Asterisk Team (asteriskteam) 2022-06-09 12:00:05.155-0500

Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1].

[1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines
By: Camillo Toselli (camillo.toselli@unibo.it) 2022-10-18 05:33:47.382-0500

Dear Joshua,

I am sorry for this delay. We have tested the patch more deeply. I signed up the Contributor License Agreement and I am ready to submit the patch.
Can we reopen this issue to the purpose?

Thanks in advance,

Camillo
By: Joshua C. Colp (jcolp) 2022-10-18 05:41:24.444-0500

Done.
By: Camillo Toselli (camillo.toselli@unibo.it) 2022-10-19 09:35:20.051-0500

Thanks. I tried to login on gerrit with my user camillo.toselli@unibo.it but I was not able. I cannot create a new user because it tells me the user already exists. Could you help me? Thanks in advance.
By: Joshua C. Colp (jcolp) 2022-10-19 09:45:15.693-0500

Your license agreement has not yet been accepted, therefore you can't access Gerrit or put changes up for review.
By: Camillo Toselli (camillo.toselli@unibo.it) 2022-10-20 04:52:41.426-0500

Thanks, I will be waiting for the license agreement acceptance.
By: Camillo Toselli (camillo.toselli@unibo.it) 2022-10-27 04:59:16.393-0500

Is there any news on license agreement acceptance?
The fact that we have another user cesia.voip@unibo.it with a signed license agreement could speed up the process?
Thanks in advance.
By: Joshua C. Colp (jcolp) 2022-10-27 05:06:10.258-0500

I've sent a request regarding it.
By: Camillo Toselli (camillo.toselli@unibo.it) 2022-11-02 09:41:20.003-0500

Dear Joshua,

I have pushed the commit 99e1a5f7638492ead4c36e14cf5194fb17ff55c2 (HEAD -> ASTERISK-30052) which introduces the send_rtcp_nack setting to decouple avpf signalling from webrtc setting.

Thank you in advance.
By: Camillo Toselli (camillo.toselli@unibo.it) 2022-11-16 02:36:35.482-0600

Dear Joshua,

the patch was rejected because should have been linked to the main branch. I will submit it again against the main branch.

Thanks,

Camillo