Summary:	ASTERISK-30001: db: Removing nonexistent entries shows "Database entry removed"
Reporter:	N A (InterLinked)	Labels:
Date Opened:	2022-03-31 06:44:09	Date Closed:	2022-06-30 19:27:59
Priority:	Trivial	Regression?
Status:	Closed/Complete	Components:	General
Versions:	18.10.0	Frequency of Occurrence	Constant
Related Issues:
Environment:		Attachments:
Description:	If you try to remove an AstDB entry that doesn't exist from the CLI, you're always told it was deleted: {noformat} pbxdev*CLI> database del foo bar Database entry removed. pbxdev*CLI> database del foo bar Database entry removed. pbxdev*CLI> database del foo bar Database entry removed. pbxdev*CLI> database del foo bar Database entry removed. {noformat} (there is no further output, even with core debug 10). I initially thought that perhaps it simply always says that, but looking at the code, there is a branch to say that the entry didn't exist: https://github.com/asterisk/asterisk/blob/master/main/db.c#L683 So there is a bug with ast_db_del not returning the proper value when entries do not exist.
Comments:	By: Asterisk Team (asteriskteam) 2022-03-31 06:44:10.135-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/]. By: Friendly Automation (friendly-automation) 2022-06-30 19:28:00.013-0500 Change 18718 merged by Friendly Automation: db: Notify user if deleted DB entry didn't exist. [https://gerrit.asterisk.org/c/asterisk/+/18718|https://gerrit.asterisk.org/c/asterisk/+/18718] By: Friendly Automation (friendly-automation) 2022-07-01 10:15:24.399-0500 Change 18716 merged by Kevin Harwell: db: Notify user if deleted DB entry didn't exist. [https://gerrit.asterisk.org/c/asterisk/+/18716|https://gerrit.asterisk.org/c/asterisk/+/18716] By: Friendly Automation (friendly-automation) 2022-07-01 10:15:46.985-0500 Change 18717 merged by Kevin Harwell: db: Notify user if deleted DB entry didn't exist. [https://gerrit.asterisk.org/c/asterisk/+/18717|https://gerrit.asterisk.org/c/asterisk/+/18717] By: Friendly Automation (friendly-automation) 2022-07-01 10:15:59.088-0500 Change 18361 merged by Kevin Harwell: db: Notify user if deleted DB entry didn't exist. [https://gerrit.asterisk.org/c/asterisk/+/18361|https://gerrit.asterisk.org/c/asterisk/+/18361]