Summary:	ASTERISK-29993: chan_dahdi: Operator control option borks both lines involved on callee disconnect
Reporter:	N A (InterLinked)	Labels:
Date Opened:	2022-03-28 13:32:17	Date Closed:	2022-05-09 08:38:14
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Channels/chan_dahdi
Versions:	18.6.0	Frequency of Occurrence	Constant
Related Issues:
Environment:		Attachments:
Description:	The "O" Dial option which only works on DAHDI to DAHDI calls is buggy in a major way. The actual "operator ringback" functionality itself works properly and as described, in both modes. However, as soon as the operator side (the called party) of a call hangs up, both lines are completely out of commission until you run "dahdi restart" in the CLI. Essentially, this makes the feature completely unusable. As soon as you dial something with the "O" option, you've just taken 2 lines out of service. Nothing comes up with "core show channels". In fact, even with core debug 10, there is no discernible activity on these channels. This is possibly/additionally a bug with DAHDI Linux as well, given that there is no indication that Asterisk is updated about hook states of affected lines. e.g. if you do "channel request hangup all" while one of these operator calls is in session, the caller will get silence and the operator will hear congestion. This persists on both sides after they go on hook and off hook again. The operator side simply hears reorder tone whenever going off hook again, for perpetuity. However, "dahdi show channel <chan-no>" (which makes an ioctl call to DAHDI) does show the correct hook state in the "borked" mode. Dialing either of the lines involved from a working line results in them being "BUSY". This is because in both cases, p->subs[SUB_REAL].allocd is true.
Comments:	By: Asterisk Team (asteriskteam) 2022-03-28 13:32:18.685-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/]. By: Friendly Automation (friendly-automation) 2022-05-09 08:38:15.959-0500 Change 18501 merged by Friendly Automation: chan_dahdi: Fix broken operator mode clearing. [https://gerrit.asterisk.org/c/asterisk/+/18501|https://gerrit.asterisk.org/c/asterisk/+/18501] By: Friendly Automation (friendly-automation) 2022-05-09 08:44:08.552-0500 Change 18502 merged by Friendly Automation: chan_dahdi: Fix broken operator mode clearing. [https://gerrit.asterisk.org/c/asterisk/+/18502|https://gerrit.asterisk.org/c/asterisk/+/18502] By: Friendly Automation (friendly-automation) 2022-05-09 08:47:42.870-0500 Change 18415 merged by Friendly Automation: chan_dahdi: Fix broken operator mode clearing. [https://gerrit.asterisk.org/c/asterisk/+/18415|https://gerrit.asterisk.org/c/asterisk/+/18415] By: Friendly Automation (friendly-automation) 2022-05-09 09:39:25.697-0500 Change 18503 merged by Joshua Colp: chan_dahdi: Fix broken operator mode clearing. [https://gerrit.asterisk.org/c/asterisk/+/18503|https://gerrit.asterisk.org/c/asterisk/+/18503]