Summary:	ASTERISK-29953: Asterisk sends 488 Unacceptable when the Bind port of RTCP fails.
Reporter:	Piyush Badkul (starlord)	Labels:
Date Opened:	2022-03-05 08:00:06.000-0600	Date Closed:	2022-03-21 12:00:01
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Channels/chan_sip/CodecHandling Channels/chan_sip/SRTP
Versions:	19.0.0 19.1.0 19.2.1	Frequency of Occurrence	Constant
Related Issues:
Environment:	This problem will come for every environment and for every release number.	Attachments:
Description:	Whenever a call establishes through asterisk Softswitch, asterisk goes out to find an available RTP port from a predefined port range given in rtp.conf. Once it finds the available port, then it attempts to bind it and if the binding of that RTP port fails, then it jumps to the next available port in the list. After binding to the RTP port correctly, just sets the RTCP port to next higher odd port number. It only attempts to bind the RTCP port once, and if it fails the asterisk doesn't care and move on to handle other things required for the setting up of a call. This problem only arises when the asterisk behaves like a media server for the encrypted call and several other applications run on the blade using the same port range. This problem is random as specified from the above description when the binding of RTCP is failed. Since RTCP is mandatory for the encrypted call.   However, it should not matter that multiple applications are running on the same blade, customer should not face failure when initiating a call. I believe that algorithm for the same can be modified and this problem can be resolved. More details at- https://app.hackernoon.com/mobile/VltlIsRerlWvDLXnr6ND If leads at asterisk believe that this is really a problem and should be addressed, I will be happy to explain the problem in more detail and I will also like to submit the patch for the following. If any better way than what I am proposing exists, I will be happy to understand it and implement it for asterisk. In case it should be fixed, please allow me to provide a patch and assign this issue to me.
Comments:	By: Asterisk Team (asteriskteam) 2022-03-05 08:00:07.030-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/]. By: Joshua C. Colp (jcolp) 2022-03-05 10:29:02.379-0600 If you wish to provide a patch then a license agreement needs to be signed, and the patch contribution process is documented on the wiki[1]. [1] https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process By: Piyush Badkul (starlord) 2022-03-06 12:02:41.686-0600 I would like to provide a patch for the same. When I go for signing of the license, it shows that my license is either pending or already approved. Also, I will follow the steps of contribution process and will soon come up with a patch. By: Joshua C. Colp (jcolp) 2022-03-07 06:38:23.870-0600 License agreements are manually reviewed by legal. Once done you can attach your patch. By: Asterisk Team (asteriskteam) 2022-03-21 12:00:00.841-0500 Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1]. [1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines