[Home]

Summary:ASTERISK-29914: 16.24.0, 18.10.0 failed to compile
Reporter:tootai (tootai)Labels:
Date Opened:2022-02-12 06:43:33.000-0600Date Closed:2022-02-14 04:32:37.000-0600
Priority:MinorRegression?Yes
Status:Closed/CompleteComponents:pjproject/pjsip
Versions:16.23.0 Frequency of
Occurrence		Constant
Related
Issues:
is duplicated byASTERISK-29915 18.10.0 failed to compile
Environment:Debian11 64bits, all previous 16.x versions compiling without problemAttachments:
Description:Copy asterisk-16.23.0 directory sources in asterisk-16.24.0 directory and apply 16.24.0-patch

When compiling after make clean && configure && make menuselect I do make and get:

{noformat}
res_pjsip/pjsip_message_filter.c: In function ‘filter_on_tx_message’:
res_pjsip/pjsip_message_filter.c:233:2: error: unknown type name ‘pjsip_sdp_info’; did you mean ‘pjsip_regc_info’?
 233 |  pjsip_sdp_info *sdp_info;
     |  ^~~~~~~~~~~~~~
     |  pjsip_regc_info
res_pjsip/pjsip_message_filter.c:339:13: warning: implicit declaration of function ‘pjsip_get_sdp_info’; did you mean ‘pjsip_get_dest_info’? [-Wimplicit-function-declaration]
 339 |  sdp_info = pjsip_get_sdp_info(tdata->pool, tdata->msg->body, NULL, &pjsip_media_type_application_sdp);
     |             ^~~~~~~~~~~~~~~~~~
     |             pjsip_get_dest_info
res_pjsip/pjsip_message_filter.c:339:11: warning: assignment to ‘int *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
 339 |  sdp_info = pjsip_get_sdp_info(tdata->pool, tdata->msg->body, NULL, &pjsip_media_type_application_sdp);
     |           ^
res_pjsip/pjsip_message_filter.c:340:14: error: request for member ‘sdp_err’ in something not a structure or union
 340 |  if (sdp_info->sdp_err != PJ_SUCCESS || !sdp_info->sdp) {
     |              ^~
res_pjsip/pjsip_message_filter.c:340:50: error: request for member ‘sdp’ in something not a structure or union
 340 |  if (sdp_info->sdp_err != PJ_SUCCESS || !sdp_info->sdp) {
     |                                                  ^~
res_pjsip/pjsip_message_filter.c:344:16: error: request for member ‘sdp’ in something not a structure or union
 344 |  sdp = sdp_info->sdp;
     |                ^~
make[1]: *** [/usr/src/asterisk-16.24.0/Makefile.rules:165 : res_pjsip/pjsip_message_filter.o] Erreur 1
make: *** [Makefile:388 : res] Erreur 2
{noformat}
Comments:By: Asterisk Team (asteriskteam) 2022-02-12 06:43:34.514-0600

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur.

Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/].
By: Joshua C. Colp (jcolp) 2022-02-12 09:46:31.235-0600

If you use the full 16.24.0 tarball does it work? Are you using bundled PJSIP? Is there a reason you use the patch file (we are considering getting rid of them).
By: Sean Bright (seanbright) 2022-02-12 09:57:19.016-0600

No issue for me on Ubuntu 21.10 with the following commands:

{noformat}
$ oreleases=downloads.asterisk.org/pub/telephony/asterisk/old-releases
$ wget -O - https://${oreleases}/asterisk-16.23.0.tar.gz | tar xzf -
$ cd asterisk-16.23.0/
$ wget -O - https://${oreleases}/asterisk-16.24.0-patch.tar.gz | tar xzfO - asterisk-16.24.0-patch | patch -p1
$ ./configure && make
{noformat}
By: tootai (tootai) 2022-02-12 10:01:52.947-0600

Yes, PJSIP bundled. Since ages we are updating using patch, much easier, no need to burn bandwidth for datas already presents. It save our world ;)
Will try the full tar.gz
By: tootai (tootai) 2022-02-12 10:04:35.145-0600

You download release 16.23 and apply patch 16.24 Our installation started from asterisk 16.4 and upgraded each version using the referent patch.
By: Sean Bright (seanbright) 2022-02-12 10:31:03.982-0600

No issue for me on Ubuntu 21.10 with the following commands:

{noformat}
$ oreleases=downloads.asterisk.org/pub/telephony/asterisk/old-releases
$ wget -O - https://${oreleases}/asterisk-16.4.0.tar.gz | tar xzf -
$ cd asterisk-16.4.0/
$ versions="\
16.4.1 \
16.5.0 16.5.1 \
16.6.0 16.6.1 16.6.2 \
16.7.0 \
16.8.0 \
16.9.0 \
16.10.0 \
16.11.0 16.11.1 \
16.12.0 \
16.13.0 \
16.14.0 16.14.1 \
16.15.0 16.15.1 \
16.16.0 16.16.1 16.16.2 \
16.17.0 \
16.18.0 \
16.19.0 16.19.1 \
16.20.0 \
16.21.0 16.21.1 \
16.22.0 \
16.23.0 \
16.24.0"
$ for ver in $versions; do wget -O - https://${oreleases}/asterisk-$ver-patch.tar.gz | tar xzfO - asterisk-$ver-patch | patch -p1; done
$ ./configure ; make -k -j 8
{noformat}
By: tootai (tootai) 2022-02-12 10:34:23.655-0600

I installed both versions from tarball and it's OK, Asterisk compiled and running. FYI Asterisk 18 was also updated with patch since version 18.4
By: Joshua C. Colp (jcolp) 2022-02-12 10:50:45.884-0600

According to [~seanbright] patching is working for him according to the method he has provided. How are you doing the patching?
By: tootai (tootai) 2022-02-12 11:11:15.999-0600

In /usr/src as root

wget https://downloads.asterisk.org/pub/telephony/asterisk/asterisk-16.24.0-patch.tar.gz
md5sum asterisk-16.24.0-patch.tar.gz |grep 1071c3c4a1daa39035fca94a12e7c3fc
untar the patch

cp dir-16.23.0 => new-dir-16.24.0
cd new-dir-16.24.0
make clean
patch --dry-run -p1 < ../asterisk-16.24.0-patch
patch -p1 < ../asterisk-16.24.0-patch
./configure
make menuselect ; + save exit as they are no changes from previous version
make
make install ;if everything goes right

By: Joshua C. Colp (jcolp) 2022-02-13 12:56:07.792-0600

Please try doing "make distclean" before doing configure, to ensure the environment is completely fresh.
By: tootai (tootai) 2022-02-14 02:41:23.045-0600

When using distclean asterisk compile without error. Thanks for your support, ticket can be closed.