Summary:	ASTERISK-29870: chan_sip doesn't send NOTIFY if mailbox not fully specified in sip.conf
Reporter:	James Bottomley (jejb)	Labels:
Date Opened:	2022-01-20 07:44:15.000-0600	Date Closed:	2022-01-20 07:50:48.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/Subscriptions
Versions:	16.16.1	Frequency of Occurrence	Constant
Related Issues:
Environment:	debian testing on x86_64	Attachments:
Description:	It's common practice in asterisk configuration files not to add '@default' to the mailbox specification for voicemails.  However, chan_sip subscribes to the stasis all:mwi topic with whatever string is passed in to the sip.conf mailbox=<box> line.  This means that unless you fully specify the mailbox with its @default extension, the MWI is subscribed on the wrong topic and it never sends out SIP notifies to SIP subscribers because stasis never notifies it when voicemail arrives. Common practice in asterisk is to check if the mailbox specification has an '@' and if not append '@default'.  I think chan_sip should do this in its MWI stasis subscription.
Comments:	By: Asterisk Team (asteriskteam) 2022-01-20 07:44:16.016-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/]. By: Joshua C. Colp (jcolp) 2022-01-20 07:50:48.698-0600 This is not a bug, and was documented in the UPGRADE.txt document as part of going from Asterisk 11 to Asterisk 12: VoiceMail: - Mailboxes defined by app_voicemail MUST be referenced by the rest of the   system as mailbox@context.  The rest of the system cannot add @default   to mailbox identifiers for app_voicemail that do not specify a context   any longer.  It is a mailbox identifier format that should only be   interpreted by app_voicemail.