Summary:	ASTERISK-29380: Add Flash AMI event to handle flash events
Reporter:	N A (InterLinked)	Labels:	patch
Date Opened:	2021-04-02 14:54:01	Date Closed:	2021-05-19 08:02:20
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Channels/General Channels/NewFeature
Versions:	18.3.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) channel.patch ( 1) manager_channels.patch ( 2) stasis_channels.c.patch ( 3) stasis_channels.h.patch ( 4) stasis_sample.patch ( 5) stasis.patch
Description:	The following patches raises AMI events upon AST_CONTROL_FLASH events so that hook flashes sent to Asterisk can be acted upon if desired. The following patch is currently in production on my switch and works as expected. It does not create a conflict with any existing functionality.
Comments:	By: Asterisk Team (asteriskteam) 2021-04-02 14:54:03.774-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/]. By: N A (InterLinked) 2021-04-02 14:55:19.629-0500 The attached files specifically add the AMI support to handle flash events. Two previous issues fixed issues in chan_sip and res_rtp_asterisk that affected when flash events were received and another fix prevents errors in file.c for flash events. By: Kevin Harwell (kharwell) 2021-04-05 11:34:32.638-0500 Thanks for the contribution! If you'd like your contribution to be included faster, you should submit your patch for code review by the Asterisk Developer Community. To do so, please follow the Code Review [1] instructions on the wiki. Be sure to: * Verify that your patch conforms to the Coding Guidelines [2] * Review the Code Review Checklist [3] for common items reviewers will look for * If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch [4] When ready, submit your patch and any tests to Gerrit [5] for code review. Thanks! [1] https://wiki.asterisk.org/wiki/display/AST/Code+Review [2] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines [3] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist [4] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation [5] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage By: Friendly Automation (friendly-automation) 2021-05-19 08:02:21.603-0500 Change 15880 merged by Joshua Colp: AMI: Add AMI event to expose hook flash events [https://gerrit.asterisk.org/c/asterisk/+/15880|https://gerrit.asterisk.org/c/asterisk/+/15880] By: Friendly Automation (friendly-automation) 2021-05-19 08:02:49.675-0500 Change 15901 merged by Joshua Colp: AMI: Add AMI event to expose hook flash events [https://gerrit.asterisk.org/c/asterisk/+/15901|https://gerrit.asterisk.org/c/asterisk/+/15901] By: Friendly Automation (friendly-automation) 2021-05-19 08:40:09.359-0500 Change 15889 merged by Friendly Automation: AMI: Add AMI event to expose hook flash events [https://gerrit.asterisk.org/c/asterisk/+/15889|https://gerrit.asterisk.org/c/asterisk/+/15889]