Summary:ASTERISK-28929: pjproject_bundled: Honor --without-pjproject.
Reporter:Alexander Traud (traud)Labels:patch
Date Opened:2020-06-02 05:18:11Date Closed:2020-06-05 09:52:34
Status:Closed/CompleteComponents:Core/BuildSystem pjproject/pjsip
Versions:16.10.0 17.4.0 Frequency of
Environment:Attachments:( 0) without_pjproject.patch
Description:Fixing my own stuff. ASTERISK-28837 is incomplete, the change creates a new issue, and its issue description is wrong actually.

*First*, the wrong issue description:
bq. {{./configure --without-pjproject --without-pjproject-bundled}} … errors
No. I did not test but just read the error message in the file {{third-party/pjproject/configure.m4}}. The code there is different: Only with
bq. {{./configure --with-pjproject --with-pjproject-bundled}}
the script {{./configure}} should error. Should, because the check is wrong because {{--with-pjproject}} is not parsed yet—when that test is executed: {{THIRD_PARTY_CONFIGURE()}} is called before {{AST_EXT_LIB_SETUP(\[PJPROJECT\] …)}}.

*Second*, the new issue:
bq. {{./configure --without-pjproject --without-pjproject-bundled}}
  [CC] libasteriskpj.c -> libasteriskpj.o
make[1]: *** No rule to make target 'pjproject.symbols', needed by 'libasteriskpj.exports'.  Stop.
make: *** [Makefile:387: main] Error 2
{noformat}because the Makefile still looks for the state of the variable {{PJPROJECT_BUNDLED}} (several times). After the change for ASTERISK-28837, the script {{./configure}} does not download the PJProject. Yehh. However, {{make}} downloads the PJProject. And because of the change for ASTERISK-28837, several build variables are not set, {{make}} enters an unexpected state.

*Third*, the incomplete part:
As mentioned already, not only the script {{./configure}} but also {{make}} downloads the PJProject if it was removed why ever.

bq. {{./configure --without-pjproject --without-pjproject-bundled}}
worked before ASTERISK-28837. Only
bq. {{./configure --without-pjproject}}
did not disable the PJProject also. Consequently, ASTERISK-28837 was not a major but just a minor issue because a workaround existed. ASTERISK-28837 was about a difference between Asterisk 13 and newer branches. In newer branches {{--without-pjproject}} is not enough to disable PJProject, you have to disable the bundled PJProject as well. That is couter-intuitive. Therefore ASTERISK-28837 was valid but the analysis and its change was wrong.

Just noticed this while testing the latest Asterisk branch. Normally, I am on Asterisk 13 and there {{PJPROJECT_BUNDLED=no}} on default and therefore I did not notice that {{make}} issue. Puh. Sorry.
Comments:By: Asterisk Team (asteriskteam) 2020-06-02 05:18:12.812-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur.

By: Alexander Traud (traud) 2020-06-02 05:23:16.798-0500

The attached patch fixes this issue. Reversing the previous change is not needed. However, I wonder if we should reverse that. And I wonder if we should remove that non-working test about the mandatory list in the file {{third-party/pjproject/configure.m4}}.

By: Friendly Automation (friendly-automation) 2020-06-05 09:52:36.606-0500

Change 14481 merged by Friendly Automation:
pjproject_bundled: Honor --without-pjproject.


By: Friendly Automation (friendly-automation) 2020-06-05 09:57:24.372-0500

Change 14480 merged by Friendly Automation:
pjproject_bundled: Honor --without-pjproject.


By: Friendly Automation (friendly-automation) 2020-06-05 10:03:10.468-0500

Change 14479 merged by Friendly Automation:
pjproject_bundled: Honor --without-pjproject.


By: Friendly Automation (friendly-automation) 2020-06-05 10:07:37.282-0500

Change 14452 merged by Friendly Automation:
pjproject_bundled: Honor --without-pjproject.