Summary: | ASTERISK-28808: [patch] test_stasis: Avoid always true warning with clang. | ||
Reporter: | Alexander Traud (traud) | Labels: | patch |
Date Opened: | 2020-04-06 06:55:41 | Date Closed: | 2020-04-07 19:01:17 |
Priority: | Trivial | Regression? | |
Status: | Closed/Complete | Components: | Tests/General |
Versions: | 13.32.0 16.9.0 17.3.0 | Frequency of Occurrence | |
Related Issues: | |||
Environment: | clang | Attachments: | ( 0) clang_test_stasis.patch |
Description: | 60 months ago, [review 4541|https://reviewboard.asterisk.org/r/4541/] (ASTERISK-24917) resolved warnings raised by the compiler clang. However, because alternative/conflicting code paths exist, some warnings got missed. Here in this case, the developer mode was activated via {{./configure --enable-dev-mode}} and the test framework was enabled via {{make menuselect}}.
Then, clang reports:{code}test_stasis.c:2205:18: error: address of array 'data->description' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] data && data->description ? data->description : "no data"); ~~ ~~~~~~^~~~~~~~~~~{code} | ||
Comments: | By: Asterisk Team (asteriskteam) 2020-04-06 06:55:42.997-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. By: Friendly Automation (friendly-automation) 2020-04-07 19:01:18.694-0500 Change 14116 merged by Friendly Automation: test_stasis: Avoid always true warning with clang. [https://gerrit.asterisk.org/c/asterisk/+/14116|https://gerrit.asterisk.org/c/asterisk/+/14116] By: Friendly Automation (friendly-automation) 2020-04-07 19:02:18.220-0500 Change 14114 merged by Friendly Automation: test_stasis: Avoid always true warning with clang. [https://gerrit.asterisk.org/c/asterisk/+/14114|https://gerrit.asterisk.org/c/asterisk/+/14114] By: Friendly Automation (friendly-automation) 2020-04-07 19:06:04.740-0500 Change 14087 merged by Friendly Automation: test_stasis: Avoid always true warning with clang. [https://gerrit.asterisk.org/c/asterisk/+/14087|https://gerrit.asterisk.org/c/asterisk/+/14087] By: Friendly Automation (friendly-automation) 2020-04-07 19:06:32.312-0500 Change 14115 merged by Friendly Automation: test_stasis: Avoid always true warning with clang. [https://gerrit.asterisk.org/c/asterisk/+/14115|https://gerrit.asterisk.org/c/asterisk/+/14115] |