[Home]

Summary:ASTERISK-28628: Debian 10.2: Warning when app_voicemail is compiling
Reporter:Stanislav Abramenkov (silentindark)Labels:patch
Date Opened:2019-11-25 02:56:15.000-0600Date Closed:2019-12-17 15:17:56.000-0600
Priority:MinorRegression?
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:13.29.2 Frequency of
Occurrence		One Time
Related
Issues:
Environment:OS: Debian 10.2 GCC: gcc (Debian 8.3.0-6) 8.3.0 kernel: 4.19.0-6-amd64 (4.19.67-2+deb10u2 (2019-11-11) x86_64)Attachments:( 0) app_voicemail_warning_info.png
( 1) compilling_after_patching.png
( 2) git_commit.png
( 3) possible_solution.patch
Description:Hello,

When I tried to compile the asterisk from source code, I got a warning with app_voicemail:

  [CC] app_voicemail.c -> app_voicemail.o
app_voicemail.c: In function ‘manager_list_voicemail_users’:
app_voicemail.c:13583:3: warning: ‘old’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  astman_append(s,
  ^~~~~~~~~~~~~~~~
   "Event: VoicemailUserEntry\r\n"
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   "%s"
   ~~~~
   "VMContext: %s\r\n"
   ~~~~~~~~~~~~~~~~~~~
   "VoiceMailbox: %s\r\n"
   ~~~~~~~~~~~~~~~~~~~~~~
   "Fullname: %s\r\n"
   ~~~~~~~~~~~~~~~~~~
   "Email: %s\r\n"
   ~~~~~~~~~~~~~~~
   "Pager: %s\r\n"
   ~~~~~~~~~~~~~~~
   "ServerEmail: %s\r\n"
   ~~~~~~~~~~~~~~~~~~~~~
   "FromString: %s\r\n"
   ~~~~~~~~~~~~~~~~~~~~
   "MailCommand: %s\r\n"
   ~~~~~~~~~~~~~~~~~~~~~
   "Language: %s\r\n"
   ~~~~~~~~~~~~~~~~~~
   "TimeZone: %s\r\n"
   ~~~~~~~~~~~~~~~~~~
   "Callback: %s\r\n"
   ~~~~~~~~~~~~~~~~~~
   "Dialout: %s\r\n"
   ~~~~~~~~~~~~~~~~~
   "UniqueID: %s\r\n"
   ~~~~~~~~~~~~~~~~~~
   "ExitContext: %s\r\n"
   ~~~~~~~~~~~~~~~~~~~~~
   "SayDurationMinimum: %d\r\n"
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   "SayEnvelope: %s\r\n"
   ~~~~~~~~~~~~~~~~~~~~~
   "SayCID: %s\r\n"
   ~~~~~~~~~~~~~~~~
   "AttachMessage: %s\r\n"
   ~~~~~~~~~~~~~~~~~~~~~~~
   "AttachmentFormat: %s\r\n"
   ~~~~~~~~~~~~~~~~~~~~~~~~~~
   "DeleteMessage: %s\r\n"
   ~~~~~~~~~~~~~~~~~~~~~~~
   "VolumeGain: %.2f\r\n"
   ~~~~~~~~~~~~~~~~~~~~~~
   "CanReview: %s\r\n"
   ~~~~~~~~~~~~~~~~~~~
   "CallOperator: %s\r\n"
   ~~~~~~~~~~~~~~~~~~~~~~
   "MaxMessageCount: %d\r\n"
   ~~~~~~~~~~~~~~~~~~~~~~~~~
   "MaxMessageLength: %d\r\n"
   ~~~~~~~~~~~~~~~~~~~~~~~~~~
   "NewMessageCount: %d\r\n"
   ~~~~~~~~~~~~~~~~~~~~~~~~~
   "OldMessageCount: %d\r\n"
   ~~~~~~~~~~~~~~~~~~~~~~~~~
#ifdef IMAP_STORAGE
~~~~~~~~~~~~~~~~~~~
   "IMAPUser: %s\r\n"
   ~~~~~~~~~~~~~~~~~~
   "IMAPServer: %s\r\n"
   ~~~~~~~~~~~~~~~~~~~~
   "IMAPPort: %s\r\n"
   ~~~~~~~~~~~~~~~~~~
   "IMAPFlags: %s\r\n"
   ~~~~~~~~~~~~~~~~~~~
#endif
~~~~~~
   "\r\n",
   ~~~~~~~
   actionid,
   ~~~~~~~~~
   vmu->context,
   ~~~~~~~~~~~~~
   vmu->mailbox,
   ~~~~~~~~~~~~~
   vmu->fullname,
   ~~~~~~~~~~~~~~
   vmu->email,
   ~~~~~~~~~~~
   vmu->pager,
   ~~~~~~~~~~~
   ast_strlen_zero(vmu->serveremail) ? serveremail : vmu->serveremail,
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   ast_strlen_zero(vmu->fromstring) ? fromstring : vmu->fromstring,
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   mailcmd,
   ~~~~~~~~
   vmu->language,
   ~~~~~~~~~~~~~~
   vmu->zonetag,
   ~~~~~~~~~~~~~
   vmu->callback,
   ~~~~~~~~~~~~~~
   vmu->dialout,
   ~~~~~~~~~~~~~
   vmu->uniqueid,
   ~~~~~~~~~~~~~~
   vmu->exit,
   ~~~~~~~~~~
   vmu->saydurationm,
   ~~~~~~~~~~~~~~~~~~
   ast_test_flag(vmu, VM_ENVELOPE) ? "Yes" : "No",
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   ast_test_flag(vmu, VM_SAYCID) ? "Yes" : "No",
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   ast_test_flag(vmu, VM_ATTACH) ? "Yes" : "No",
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   vmu->attachfmt,
   ~~~~~~~~~~~~~~~
   ast_test_flag(vmu, VM_DELETE) ? "Yes" : "No",
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   vmu->volgain,
   ~~~~~~~~~~~~~
   ast_test_flag(vmu, VM_REVIEW) ? "Yes" : "No",
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   ast_test_flag(vmu, VM_OPERATOR) ? "Yes" : "No",
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   vmu->maxmsg,
   ~~~~~~~~~~~~
   vmu->maxsecs,
   ~~~~~~~~~~~~~
   new,
   ~~~~
   old
   ~~~
#ifdef IMAP_STORAGE
~~~~~~~~~~~~~~~~~~~
   ,
   ~
   vmu->imapuser,
   ~~~~~~~~~~~~~~
   vmu->imapserver,
   ~~~~~~~~~~~~~~~~
   vmu->imapport,
   ~~~~~~~~~~~~~~
   vmu->imapflags
   ~~~~~~~~~~~~~~
#endif
~~~~~~
   );
   ~
app_voicemail.c:13583:3: warning: ‘new’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  [LD] app_voicemail.o -> app_voicemail.so


best regards,
Stanislav
Comments:By: Asterisk Team (asteriskteam) 2019-11-25 02:56:18.266-0600

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur.
By: Stanislav Abramenkov (silentindark) 2019-11-25 03:58:52.848-0600

screenshot
By: Stanislav Abramenkov (silentindark) 2019-11-25 04:25:30.500-0600

This patch should to solve this issue
By: Stanislav Abramenkov (silentindark) 2019-11-25 04:28:16.110-0600

compiling after patching
By: Benjamin Keith Ford (bford) 2019-11-25 09:50:36.943-0600

Hello, did your patch fix the issue for you?
By: Stanislav Abramenkov (silentindark) 2019-11-25 09:58:19.378-0600

hello, Yes, warning is gone.
By: Benjamin Keith Ford (bford) 2019-11-25 10:14:36.724-0600

Would you be interested in submitting your patch to Gerrit[1] for code review? There's a wiki page[2] that details everything you need to do to get the process started.

[1]: https://gerrit.asterisk.org/q/status:open
[2]: https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage
By: Stanislav Abramenkov (silentindark) 2019-11-25 12:30:11.435-0600

I have requested access to Gerrit. I will try to submit the patch to Gerrit for code review.
But if your want, you can add the patch by yourself.
By: Joshua C. Colp (jcolp) 2019-12-10 05:25:00.777-0600

There is currently no change up for review for this. A commit only does a commit locally, did you follow the rest of the instructions and use "git review" to place it up for review?
By: Friendly Automation (friendly-automation) 2019-12-17 11:58:27.296-0600

Change 13420 merged by Friendly Automation:
app_voicemail: warning when is compiling

[https://gerrit.asterisk.org/c/asterisk/+/13420|https://gerrit.asterisk.org/c/asterisk/+/13420]