Summary:ASTERISK-27634: Determine if the internal editline and stdtime libraries are still relevant
Reporter:George Joseph (gjoseph)Labels:
Date Opened:2018-01-29 08:54:24.000-0600Date Closed:2018-02-13 08:23:51.000-0600
Versions:13.19.0 GIT 15.2.0 Frequency of
Description:Determine if the editline and stdtime libraries includes in the source tree are still relevant and remove them if not.
Comments:By: Corey Farrell (coreyfarrell) 2018-01-29 11:01:48.332-0600

stdtime is used for time formatting and to determine local timezone.  I'm unsure if stdtime is available as a shared library but using such a library would require writing a new unit to replace the symbols exported by stdtime/localtime.o.

By: Friendly Automation (friendly-automation) 2018-02-13 08:23:52.818-0600

Change 8187 merged by Jenkins2:
core: Remove embedded editline.


By: Alexander Traud (traud) 2018-02-14 02:45:25.724-0600

Currently, {{./configure}} requires the tool {{pkg-config}} to find the system-provided libedit development-headers. Consequently, another requirement was added by this change as a side-effect and not mentioned in the file CHANGES. However, that requirement was added to the script {{contrib/scripts/install_prereq}}.

Another issue: OpenBSD 6.2, see ASTERISK-27677

By: Alexander Traud (traud) 2018-02-16 04:46:31.718-0600

The internal libraries for the audio-codecs
* GSM, see ASTERISK-27558
* iLBC, see ASTERISK-27669
* LPC10, see ASTERISK-27580

should be investigated as well. LPC10 does not have an active maintainer anymore, but got a rival audio codec through Codec 2.

By: Alexander Traud (traud) 2018-03-02 07:43:33.150-0600

In the file {{configure.ac}}, what about the stuff related to {{EDITLINE_LIB}}? The symbols {{tgetent(.)}} and {{initscr(.)}} are not required anymore in master. In branch 13 and branch 15, that stuff were not required when the external editline library is used. Are they? I am not sure how the module {{menuselect}} links to -l\{n\}curses. Furthermore, I have not found a platform yet, which does not have those dependencies installed, when all the other mandatory dependencies are installed. Therefore, it is a bit difficult to test this. For me, it looks like
* in master, this whole {{EDITLINE_LIB}} part can be removed, and
* in branch 13/15, that part should be moved further down into a {{if test "$PBX_LIBEDIT" != "1"; then}}.

This is discusses further in ASTERISK-27761.