| Summary: | ASTERISK-27540: test_config: Missing XML documentation | ||
| Reporter: | Corey Farrell (coreyfarrell) | Labels: | |
| Date Opened: | 2018-01-02 12:34:44.000-0600 | Date Closed: | |
| Priority: | Minor | Regression? | |
| Status: | Open/New | Components: | Tests/General |
| Versions: | GIT | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | test_config.c has no XML documentation so code which processes options is not fully covered. | ||
| Comments: | By: Asterisk Team (asteriskteam) 2018-01-02 12:34:45.203-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Corey Farrell (coreyfarrell) 2018-01-02 13:13:21.158-0600 Additional question: why didn't the assert cause a crash? See https://gerrit.asterisk.org/#/c/7784/1/main/config_options.c@1138 By: Corey Farrell (coreyfarrell) 2018-01-02 14:07:10.691-0600 test_config uses CONFIG_INFO_TEST which sets .hidden = 1, this causes link_option_to_types to skip xmldoc_update_config_option(). Fixing this will require using the normal CONFIG_INFO_STANDARD and just let the test not be hidden. | ||