[Home]

Summary:ASTERISK-27333: sip_to_pjsip not correctly handling disallow=all directive
Reporter:Torrey Searle (tsearle)Labels:pjsip
Date Opened:2017-10-12 03:02:29Date Closed:2017-10-17 10:00:11
Priority:MajorRegression?
Status:Closed/CompleteComponents:Contrib/General
Versions:13.15.1 Frequency of
Occurrence		Constant
Related
Issues:
Environment:Attachments:( 0) pjsip.conf
( 1) sip.conf
Description:chan_sip allowed for allowed codecs to be defined in the global section, these codecs would be merged into the list of codecs offered by the peer.

However if a peer defines disallow=all then  the codecs defined in the global allow section should not be added to the peer's list of codecs

Attached is a config file that can be used to test
Comments:By: Asterisk Team (asteriskteam) 2017-10-12 03:02:30.373-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].
By: Torrey Searle (tsearle) 2017-10-12 03:06:03.473-0500

example input&output file
By: Friendly Automation (friendly-automation) 2017-10-17 09:07:25.651-0500

Change 6741 merged by Jenkins2:
contrib/script/sip_to_pjsip: implement 'all' for allow/disallow

[https://gerrit.asterisk.org/6741|https://gerrit.asterisk.org/6741]
By: Friendly Automation (friendly-automation) 2017-10-17 09:32:42.207-0500

Change 6811 merged by Jenkins2:
contrib/script/sip_to_pjsip: implement 'all' for allow/disallow

[https://gerrit.asterisk.org/6811|https://gerrit.asterisk.org/6811]
By: Friendly Automation (friendly-automation) 2017-10-17 09:39:33.841-0500

Change 6810 merged by Joshua Colp:
contrib/script/sip_to_pjsip: implement 'all' for allow/disallow

[https://gerrit.asterisk.org/6810|https://gerrit.asterisk.org/6810]
By: Max Norba (miralin) 2017-10-20 06:14:06.328-0500

I see mixing the use of tabs and spaces in this patch.
By: Alexander Traud (traud) 2018-04-18 02:36:57.358-0500

[~miralin], thanks for that note. I fixed that as a side effect of ASTERISK-27811. Please, have a look and double-check. Digium has problems to use bug trackers and a lot of good comments get drown here. Therefore, it is always good—even for minor and trivial things—to create a new issue.