| Summary: | ASTERISK-27195: chan_sip: only sets ToS bits on UDP socket, ignoring TCP and TLS sockets | ||
| Reporter: | Joshua Roys (roysjosh) | Labels: | |
| Date Opened: | 2017-08-10 21:14:18 | Date Closed: | 2020-04-16 10:22:00 |
| Priority: | Minor | Regression? | |
| Status: | Closed/Complete | Components: | Channels/chan_sip/TCP-TLS |
| Versions: | 13.17.0 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | chan_sip only calls ast_set_qos for the UDP socket, ignoring the TCP and TLS sockets. tcpdump confirms that all outgoing packets from the TLS port have "tos 0x0".
| ||
| Comments: | By: Asterisk Team (asteriskteam) 2017-08-10 21:14:19.331-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Joshua C. Colp (jcolp) 2017-08-14 11:05:48.390-0500 This issue is being acknowledged but the chan_sip module is community supported, so there is no time frame on when this will get looked into. If you have a patch you can attach it or ideally place it up for review on Gerrit. By: Friendly Automation (friendly-automation) 2020-04-16 10:22:01.953-0500 Change 14211 merged by Friendly Automation: chan_sip: DiffServ/ToS not only on UDP but also on TCP and TLS sockets. [https://gerrit.asterisk.org/c/asterisk/+/14211|https://gerrit.asterisk.org/c/asterisk/+/14211] By: Friendly Automation (friendly-automation) 2020-04-16 10:36:44.891-0500 Change 14232 merged by George Joseph: chan_sip: DiffServ/ToS not only on UDP but also on TCP and TLS sockets. [https://gerrit.asterisk.org/c/asterisk/+/14232|https://gerrit.asterisk.org/c/asterisk/+/14232] By: Friendly Automation (friendly-automation) 2020-04-16 10:36:59.844-0500 Change 14233 merged by George Joseph: chan_sip: DiffServ/ToS not only on UDP but also on TCP and TLS sockets. [https://gerrit.asterisk.org/c/asterisk/+/14233|https://gerrit.asterisk.org/c/asterisk/+/14233] By: Friendly Automation (friendly-automation) 2020-04-16 10:37:21.303-0500 Change 14231 merged by George Joseph: chan_sip: DiffServ/ToS not only on UDP but also on TCP and TLS sockets. [https://gerrit.asterisk.org/c/asterisk/+/14231|https://gerrit.asterisk.org/c/asterisk/+/14231] | ||