[Home]

Summary:ASTERISK-26710: [patch] res_rtp_asterisk: CHANNEL arguments, (rtcp,all_rtt),(rtcp,all_loss),(rtcp,all_jitter) always return 0
Reporter:Aaron An (aaron)Labels:
Date Opened:2017-01-09 21:50:05.000-0600Date Closed:2017-01-12 19:48:23.000-0600
Priority:CriticalRegression?
Status:Closed/CompleteComponents:Resources/res_rtp_asterisk
Versions:13.8.0 Frequency of
Occurrence		Constant
Related
Issues:
duplicatesASTERISK-24584 RTP QOS Channel variables not being set correctly
Environment:CentOS6.5-X64Attachments:
Description:Function "CHANNEL(rtcp,all_rtt)" "CHANNEL(rtcp,all_loss)" "CHANNEL(rtcp,all_jitter)" always return 0 due to the wrong define of macro "AST_RTP_SATA_SET" and "AST_RTP_STAT_STRCPY".
{noformat}
if (stat == current_stat || stat == AST_RTP_INSTANCE_STAT_ALL || (combined >= 0 && combined == current_stat)) { \
{noformat}
should be:
{noformat}
if (stat == current_stat || stat == AST_RTP_INSTANCE_STAT_ALL || (combined >= 0 && combined == stat)) { \
{noformat}
Comments:By: Asterisk Team (asteriskteam) 2017-01-09 21:50:06.102-0600

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].
By: Aaron An (aaron) 2017-01-09 21:53:14.581-0600

I will submit the patch for code review to Gerrit soon.
By: Friendly Automation (friendly-automation) 2017-01-12 19:48:24.289-0600

Change 4709 merged by zuul:
res_rtp_asterisk:  Fix bug in function CHANNEL(rtcp, all_rtt)

[https://gerrit.asterisk.org/4709|https://gerrit.asterisk.org/4709]
By: Friendly Automation (friendly-automation) 2017-01-12 19:54:56.978-0600

Change 4708 merged by zuul:
res_rtp_asterisk:  Fix bug in function CHANNEL(rtcp, all_rtt)

[https://gerrit.asterisk.org/4708|https://gerrit.asterisk.org/4708]
By: Friendly Automation (friendly-automation) 2017-01-12 19:56:16.370-0600

Change 4707 merged by Joshua Colp:
res_rtp_asterisk:  Fix bug in function CHANNEL(rtcp, all_rtt)

[https://gerrit.asterisk.org/4707|https://gerrit.asterisk.org/4707]