[Home]

Summary:ASTERISK-26613: format_wav: wav16 format read file only by 320 - half of frame
Reporter:Vitaly K (bg1)Labels:
Date Opened:2016-11-19 05:38:18.000-0600Date Closed:2017-04-19 09:58:32
Priority:MajorRegression?
Status:Closed/CompleteComponents:Formats/format_wav
Versions:13.4.0 13.7.0 Frequency of
Occurrence		Constant
Related
Issues:
Environment:Ubuntu 14.04.5 LTS Linux XXX 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:32 UTC 2016 i686 i686 i686 GNU/LinuxAttachments:( 0) wav16_readed_by_320bytes_bugfix.patch
Description:format_wav.c in function wav_read() test fs-hz in line
bytes = (fs->hz == 16000 ? (WAV_BUF_SIZE * 2) : WAV_BUF_SIZE);

but fs->hz never set and always 0 by default

This cause read only 1/2 of frame for wav16 files.
For outgoing channels cause send only 320 bytes of data.
For incoming channels send 640  maybe smoother in effect.

For repeat problem run from CLI something like

channel originate SIP/200@SIP_HOST application  Playback               7bx.ru_armin_van_buuren_feat._cindy_alma_-_beautiful_life_radio_edit.riff.le

when
a) 7bx.ru_armin_van_buuren_feat._cindy_alma_-_beautiful_life_radio_edit.riff.le.wav16 is 16000 Hz 1channel 16 bit RIFF file

b) only slin16 codec enabled for SIP_HOST by
disallow=all
allow=slin16


I think all version of asterisk minimum since 13.4.0 affected by this bug.

Comments:By: Asterisk Team (asteriskteam) 2016-11-19 05:38:20.855-0600

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].
By: Rusty Newton (rnewton) 2016-11-23 15:51:14.570-0600

Would you like to submit a patch for the issue?

https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process

That would help this move through more quickly!
By: Vitaly K (bg1) 2016-11-24 22:01:18.207-0600

Patch attached
By: Vitaly K (bg1) 2016-11-24 22:02:24.832-0600

Patch added as attachment.
Also download and review asterisk-14.2.0 - same problem found.
By: Joshua C. Colp (jcolp) 2016-11-28 06:19:36.332-0600

Same here!
By: Asterisk Team (asteriskteam) 2016-12-12 12:00:01.247-0600

Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1].

[1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines
By: Friendly Automation (friendly-automation) 2017-04-19 08:39:59.563-0500

Change 5478 merged by Joshua Colp:
format_wav: Read 16khz wav samples properly

[https://gerrit.asterisk.org/5478|https://gerrit.asterisk.org/5478]
By: Friendly Automation (friendly-automation) 2017-04-19 08:40:10.309-0500

Change 5479 merged by Joshua Colp:
format_wav: Read 16khz wav samples properly

[https://gerrit.asterisk.org/5479|https://gerrit.asterisk.org/5479]
By: Friendly Automation (friendly-automation) 2017-04-19 08:40:17.950-0500

Change 5480 merged by Joshua Colp:
format_wav: Read 16khz wav samples properly

[https://gerrit.asterisk.org/5480|https://gerrit.asterisk.org/5480]