| Summary: | ASTERISK-26255: Fix includes of sys/signal.h | ||
| Reporter: | Seamus Caveney (scv) | Labels: | |
| Date Opened: | 2016-08-01 19:53:29 | Date Closed: | 2016-08-01 19:55:36 |
| Priority: | Trivial | Regression? | |
| Status: | Closed/Complete | Components: | Core/Portability |
| Versions: | 13.10.0 14.0.0-beta1 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | musl libc 1.1.14, gcc 5.3, x86_64 | Attachments: | |
| Description: | Numerous files include <sys/signal.h> incorrectly, the proper include across all platforms should just be <signal.h>. Modern revisions of glibc silently redirect <sys/signal.h> to <signal.h>, while musl does output a warning:
#warning redirecting incorrect #include <sys/signal.h> to <signal.h> The patch replaces all occurrences of <sys/signal.h> with <signal.h>. Additionally there were a few locations with preprocessor checks that were made redundant: - apps/app_dahdiras.c - removed __linux__ check - channels/chan_dahdi.c - removed __NetBSD__ || __FreeBSD__ check - pbx/pbx_dundi.c - moved signal.h and ifaddrs.h includes outside of BSD/OSX as they are not platform specific If the ifaddrs.h related modification should be split into another issue ticket, please let me know. I will be submitting the patch to Gerrit momentarily | ||
| Comments: | By: Asterisk Team (asteriskteam) 2016-08-01 19:53:30.197-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Seamus Caveney (scv) 2016-08-01 19:56:16.070-0500 This was already fixed in 39b69ab5 . By: Asterisk Team (asteriskteam) 2016-08-01 19:56:16.222-0500 This issue has been reopened as a result of your commenting on it as the reporter. It will be triaged once again as applicable. | ||