ASTERISK-26119: [patch] fix: memory leaks, resource leaks, out of bounds and bugs

[Home]

Summary: ASTERISK-26119: [patch] fix: memory leaks, resource leaks, out of bounds and bugs

Reporter: Alexei Gradinari (alexei gradinari) Labels:

Date Opened: 2016-06-16 15:41:46 Date Closed: 2016-07-11 13:50:26

Priority: Major Regression?

Status: Closed/Complete Components: Core/General Resources/res_phoneprov Resources/res_pjsip_sdp_rtp

Versions: 13.9.1 Frequency of
Occurrence

Related
Issues:

Environment: Attachments:

Description: Fixed memory leaks in
- main/ast_expr2.y
- res/ael/pval.c

Fixed resource leaks in
- res/res_phoneprov.c

Fixed accessing buffer out of bounds in
- main/say.c

Fixed bug checking pointer arithmetic result instead of value by index

Comments: By: Asterisk Team (asteriskteam) 2016-06-16 15:41:47.377-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].
By: Rusty Newton (rnewton) 2016-06-16 19:04:11.942-0500

Thanks for your work [~alexei gradinari]!!
By: ibercom (ibercom) 2016-07-11 12:43:11.175-0500

[~alexei gradinari]: I think so, the patch to main/ast_expr2.y and main/ast_expr2.c has introduced a leaks in error paths.

{noformat}
if (vs == NULL) {
ast_log(LOG_WARNING, "malloc() failed\n");
return NULL;
}
{noformat}

It needs a:

{noformat}
free_value(a);
free_value(b);
{noformat}

before "return NULL".

By: Richard Mudgett (rmudgett) 2016-07-11 13:50:18.762-0500

[~ibercom] Thanks for pointing out the off-nominal memory leak. I've put up a patch to fix it. I'm closing this issue that should have been auto-closed when the original patch was merged.