Summary:	ASTERISK-25974: Unused realtime MOH classes not purged on 'moh reload'
Reporter:	Sébastien Couture (sysreq)	Labels:
Date Opened:	2016-04-29 09:33:56	Date Closed:	2017-04-05 19:15:45
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Resources/res_musiconhold
Versions:	11.22.0	Frequency of Occurrence	Constant
Related Issues:
Environment:	Linux 3.5.0-48-generic #72~precise1-Ubuntu SMP Tue Mar 11 20:09:08 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux	Attachments:
Description:	Unused realtime MOH classes are not purged from memory when a 'moh reload' is issued _unless_ musiconhold.conf file is missing, invalid, or was modified (a simple 'touch' will suffice). Looking at the first few lines of code from the 'load_moh_classes()' function in res_musiconhold.c, you can see pretty clearly why we get this behaviour. That being said, it leaves out this specific scenario where you would expect realtime classes to be reloaded/purged whether musiconhold.conf was modified or not. cachertclasses=yes
Comments:	By: Asterisk Team (asteriskteam) 2016-04-29 09:33:57.660-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Sébastien Couture (sysreq) 2016-05-17 10:06:35.639-0500 Since this seems to be a clone of an issue on the internal Digium JIRA, am I to think that you guys were/are already aware of the problem and working on a fix? Will you also be updating this issue as the internal JIRA issue gets updated? Any idea when this could be fixed? Thank you! By: Joshua C. Colp (jcolp) 2016-05-17 10:19:12.424-0500 Internal issues are for internal resource management. Anything relating to the issue goes on the public issue. I have no timeline on when it would be fixed. By: Friendly Automation (friendly-automation) 2017-04-05 19:15:46.769-0500 Change 5321 merged by zuul: Unused realtime MOH classes not purged on 'moh reload' [https://gerrit.asterisk.org/5321|https://gerrit.asterisk.org/5321] By: Friendly Automation (friendly-automation) 2017-04-05 19:21:46.717-0500 Change 5320 merged by Joshua Colp: Unused realtime MOH classes not purged on 'moh reload' [https://gerrit.asterisk.org/5320|https://gerrit.asterisk.org/5320] By: Friendly Automation (friendly-automation) 2017-04-06 04:32:50.012-0500 Change 5319 merged by Joshua Colp: Unused realtime MOH classes not purged on 'moh reload' [https://gerrit.asterisk.org/5319|https://gerrit.asterisk.org/5319]