Summary:ASTERISK-25956: Compilation error in conditionally compiled code in config_options.c
Reporter:Chris Trobridge (chris.trobridge@ultra-aep.com)Labels:
Date Opened:2016-04-25 07:25:54Date Closed:2016-05-09 05:06:21
Versions:13.8.2 Frequency of
Environment:Yocto 2.1 AST_XML_DOCS not definedAttachments:( 0) fix-config_options.patch
Description:config_options.c contains an ifdef that does not completely contain an if statement, leading to syntax errors when AST_XML_DOCS is not defined.

Current code section follows (config_options.c:195), swapping the last two lines fixes the compilation.
if (!info->hidden && !opt->no_doc &&
xmldoc_update_config_option(types, info->module, opt->name, type->name, opt->default_val, opt->match_type == ACO_REGEX, opt->type)) {
opt->doc_unavailable = 1;
Comments:By: Asterisk Team (asteriskteam) 2016-04-25 07:25:55.357-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

By: Rusty Newton (rnewton) 2016-04-25 09:42:10.299-0500

[~chris.trobridge@ultra-aep.com] thanks for the report!

Do you want to file a patch on Gerrit and get credit for the fix?


By: Chris Trobridge (chris.trobridge@ultra-aep.com) 2016-04-25 11:01:15.708-0500

I would like to but it may take a little time as I will need to pick up this process from scratch.

By: Rusty Newton (rnewton) 2016-04-25 15:04:34.941-0500

That's alright. If you need any help with the process feel free to pop in the #asterisk-dev channel on irc.freenode.net or post on the asterisk-dev mailing list at lists.digium.com.

By: Chris Trobridge (chris.trobridge@ultra-aep.com) 2016-04-27 01:08:17.475-0500

First thing is getting the Gerrit account sorted - I've passed that by our legal representative and submitted the agreement; waiting for access.

By: Chris Trobridge (chris.trobridge@ultra-aep.com) 2016-05-03 09:53:53.127-0500

The licence agreement has be made but I still cannot access Gerrit.
I am not totally sure what my user name should be for it but in any case it appears Gerrit may not be online.  I am following the instructions on https://gerrit.asterisk.org/.

This morning, the main site referenced (https://gerrit.asterisk.org/) yielded 503 "The server is temporarily unable to service your request due to maintenance downtime or capacity problems. Please try again later".

Accessing git via ssh gave "ssh: connect to host gerrit.asterisk.org port 29418: Connection refused".

I would like to work through Gerrit but, for now, I have attached the patch.

By: Joshua C. Colp (jcolp) 2016-05-03 09:58:14.706-0500

You may have caught Gerrit when it was restarting but as of right now it is online. As well during those times it is down for 1-2 minutes at the most.

By: Chris Trobridge (chris.trobridge@ultra-aep.com) 2016-05-09 02:36:29.851-0500

I have submitted the fix via gerrit and it's been accepted and merged into main and 13.
I take it this issue is now dealt with and can be closed?