| Summary: | ASTERISK-25219: [patch]Source and destination overlap in memcpy in rtp_engine.c | ||
| Reporter: | Walter Doekes (wdoekes) | Labels: | |
| Date Opened: | 2015-07-01 04:03:07 | Date Closed: | 2015-07-02 07:54:17 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/RTP |
| Versions: | 11.18.0 | Frequency of Occurrence | Constant |
| Related Issues: | |||
| Environment: | Attachments: | ( 0) issueA25219-memcpy_overlap_rtp_engine.patch | |
| Description: | Valgrind says:
{noformat} ==32423== Source and destination overlap in memcpy(0x85a920, 0x85a920, 304) ==32423== at 0x4C2F71C: memcpy@@GLIBC_2.14 (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==32423== by 0x55BA91: ast_rtp_engine_unload_format (rtp_engine.c:2292) ==32423== by 0x4EEFB7: ast_format_attr_unreg_interface (format.c:1437) ==32423== by 0x29F6B478: unload_module (res_format_attr_h263.c:271) ==32423== by 0x5032ED: ast_module_shutdown (loader.c:568) ==32423== by 0x4453AD: really_quit (asterisk.c:1812) ==32423== by 0x44503F: quit_handler (asterisk.c:1729) ==32423== by 0x446245: handle_stop_gracefully (asterisk.c:2230) ==32423== by 0x4A20D5: ast_cli_command_full (cli.c:2693) ==32423== by 0x445D78: consolehandler (asterisk.c:2087) ==32423== by 0x44CE5C: main (asterisk.c:4405) {noformat} Which happens here: {noformat} ast_rtp_mime_types[y] = ast_rtp_mime_types[x]; {noformat} Attaching patch that fixes it. Cheers, Walter Doekes OSSO B.V. | ||
| Comments: | By: Asterisk Team (asteriskteam) 2015-07-01 04:03:10.304-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Rusty Newton (rnewton) 2015-07-01 13:48:42.925-0500 Once you get your recent issues up on Gerrit, don't forget to add the Gerrit links back onto the JIRA issues. Thanks Walter! | ||