| Summary: | ASTERISK-25041: [patch]Broken column type checking in res_config_mysql addon | ||||
| Reporter: | Alexandre Fournier (alexandre.fournier) | Labels: | realtime | ||
| Date Opened: | 2015-04-30 20:27:53 | Date Closed: | 2015-05-13 18:53:09 | ||
| Priority: | Trivial | Regression? | No | ||
| Status: | Closed/Complete | Components: | Addons/res_config_mysql | ||
| Versions: | 11.18.0 13.3.2 | Frequency of Occurrence | Constant | ||
| Related Issues: |
| ||||
| Environment: | Attachments: | ( 0) fix-res_config_mysql-column-type-checking.diff.txt | |||
| Description: | The improved real-time queue logging, introduced by [~coolmig] in 2010 does not work with a MySQL (or MariaDB) database since column type checking is broken in the _res_config_mysql_ add-on.
Nevertheless, it is still possible to use this feature with _res_config_odbc_ and a MySQL connector or _res_config_pgsql_ as stated in the original patch proposal: ASTERISK-15863 This might affect all versions of asterisk since 1.8 to current. To know if your version of Asterisk is affected by this bug, you'll get this error message in the CLI: {noformat} res_config_mysql.c:XXXX require_mysql: Realtime table queue_log@db: Column time cannot be a datetime) {noformat} Also, this might be related: ASTERISK-18252 Please review the patch in attachment It fixes MySQL type checking for DATETIME, DATE and FLOAT types in _res_config_mysql_. | ||||
| Comments: | By: Rusty Newton (rnewton) 2015-05-03 08:41:12.588-0500 Alexandre - reattach the patch once your CLA is approved and then we'll be able to see it. Then use "Send Back" or "Enter Feedback" to send the issue back to us. Thanks. By: Alexandre Fournier (alexandre.fournier) 2015-05-05 16:51:09.275-0500 Rusty - CLA is approved, patch reattached. Thanks. By: Rusty Newton (rnewton) 2015-05-07 18:29:36.828-0500 Thanks. Opening this up. res_config_mysql is extended support and therefore supported by the community so response time may reflect that. If you want it to get pushed in faster, follow the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process] and get it up for review on Gerrit. Thanks! By: Alexandre Fournier (alexandre.fournier) 2015-05-09 10:09:27.390-0500 Gerrit review request done in master. By: Alexandre Fournier (alexandre.fournier) 2015-05-13 16:48:05.301-0500 This patch got merged into master/11/13. Thanks for your help. | ||||