Summary:ASTERISK-24742: [patch] Fix ast_odbc_find_table function in res_odbc
Reporter:ibercom (ibercom)Labels:
Date Opened:2015-01-30 18:28:01.000-0600Date Closed:2015-02-08 20:34:53.000-0600
Versions:11.14.0 Frequency of
Environment:Attachments:( 0) patch.diff
Description:I was logging mysql usage with Asterisk-11 realtime and I have seen two "SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED" commands before each UPDATE operation.

Whereas, there was only one before each SELECT or INSERT operation.
Comments:By: ibercom (ibercom) 2015-01-31 05:36:05.584-0600

The patch is trivial, just rearranges the call to ast_odbc_request_obj function. This isn't necessary when the table is cached.

By: Rusty Newton (rnewton) 2015-02-02 18:05:27.062-0600

Improvements are pushed into trunk. Your version field says 1.8 and you mention 11 in the description.

Have you tested on trunk?

if you have tested on trunk, then the next step is to get the patch on reviewboard: [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].


By: ibercom (ibercom) 2015-02-03 09:14:34.950-0600

This patch only fixes an anomalous behavior. It doesn't change anything, only corrected it.
SELECT or INSERT operation generate a single command "SET SESSION ..." in database.
UPDATE operation generates two commands "SET SESSION ..." in database and it is incorrect.

By: Rusty Newton (rnewton) 2015-02-03 16:58:52.132-0600

Okay. I see the you changed the issue type, thanks. Remember to link the reviewboard URL here after you get the patch on reviewboard.

By: Matt Jordan (mjordan) 2015-02-08 21:05:45.280-0600

Thanks for the contribution!