Summary:ASTERISK-23545: Confbridge talker detection settings configuration load bug
Reporter:John Knott (johnknott)Labels:
Date Opened:2014-03-27 06:40:23Date Closed:2014-04-08 13:00:23
Versions:SVN 11.8.1 Frequency of
Description:When dsp_talking_threshold and dsp_silence_threshold are loaded from the Confbridge config they both appear to be written to silence_threshold attribute of the user profile.

This has the effect of the user not being able to change the talking_threshold, and the silence_threshold is incorrectly set to the talking threshold too.

What appears to be the erroneous line is in apps/confbridge/conf_config_parser.c
aco_option_register(&cfg_info, "dsp_silence_threshold", ACO_EXACT, user_types, __stringify(DEFAULT_SILENCE_THRESHOLD), OPT_UINT_T, 0, FLDSET(struct user_profile, silence_threshold));
aco_option_register(&cfg_info, "dsp_talking_threshold", ACO_EXACT, user_types, __stringify(DEFAULT_TALKING_THRESHOLD), OPT_UINT_T, 0, FLDSET(struct user_profile, silence_threshold));

The obvious fix is to change the second silence_threshold to talking_threshold in the snippet above. My license agreement hasn't been finalised yet so I can't submit a patch .
Comments:By: Rusty Newton (rnewton) 2014-04-07 10:36:37.587-0500

John, if there is an issue with your license agreement, you should have received an E-mail from Michelle regarding that.  Let me know if you have any questions about it.

By: Justin Korkiner (jkorkiner) 2016-04-04 14:09:59.455-0500

This bug is still present in 11.6-cert13, the changes look to have never been merged with this branch.


Same fix applies.

By: Joshua C. Colp (jcolp) 2016-04-04 14:14:00.779-0500

[~jkorkiner] The certified branch only receives fixes as a result of specific testing done on it or as a result of issues fixed from customer reported problems. It does not receive every fix that goes into 11 and thus the fix was not put into it.

By: Justin Korkiner (jkorkiner) 2016-04-04 14:22:39.669-0500

Makes sense. What would be the proper way to suggest this fix get added? It seems corrected in the 13-cert branch.

By: Malcolm Davenport (mdavenport) 2016-04-04 14:39:26.017-0500


11.6 was first tagged as 11.6.0-rc1 on September 19, 2013.
11.6-cert was first branched from 11.6 on October 22, 2013.
The  fix for this issue went into the 11 branch on April 8, 2014, which first found its way into 11.10.

Since that time, there has not been another branching of 11-cert.  There have been many additional minor releases of 11.6-cert, we're currently at 11.6-cert13, but none of those additional releases have been precipitated by one of Digium's SLA customers who mandated the inclusion (back-porting) of that particular patch - more about the -cert branches at https://www.digium.com/products/asterisk/certified-asterisk