Summary: | ASTERISK-22537: Create Sorcery equivalent to the AST_CONFIG function | ||
Reporter: | George Joseph (gjoseph) | Labels: | |
Date Opened: | 2013-09-15 19:51:48 | Date Closed: | 2014-02-21 11:11:02.000-0600 |
Priority: | Minor | Regression? | |
Status: | Closed/Complete | Components: | Core/Sorcery |
Versions: | 12.0.0-alpha1 | Frequency of Occurrence | |
Related Issues: | |||
Environment: | Attachments: | ||
Description: | The AST_CONFIG function won't properly read sorcery based config files like pjsip.conf and res_digium_phone.conf which can have multiple sections with the same name. | ||
Comments: | By: George Joseph (gjoseph) 2013-09-15 19:55:27.226-0500 I'm going to work this one. By: Rusty Newton (rnewton) 2013-09-17 13:32:40.967-0500 Thanks George! By: Joshua C. Colp (jcolp) 2014-02-03 20:41:25.923-0600 Hey George - I was just curious if you were still going to look at doing this. Cheers. By: George Joseph (gjoseph) 2014-02-03 22:09:14.560-0600 I think I put it off because there didn't seem to be an easy way for a dialplan function to get access to the various module's sorcery instances. I've got time so let me look at it again and if you've got any direction, let me know. By: Joshua C. Colp (jcolp) 2014-02-04 06:15:56.338-0600 Yeah, everything is still isolated. Having the ability to individually grab a sorcery instance without having to have a defined interface from the module instantiating it could be useful, but you'd still need to have a unique identifier for it. By: George Joseph (gjoseph) 2014-02-04 10:51:50.014-0600 How about this... Convert ast_sorcery_open(void) to __ast_sorcery_open(char *module) Then define ast_sorcery_open() __ast_sorcery_open(AST_MODULE) Then in __ast_sorcery_open, insert into a hashtable with the module name as the key and the sorcery object as the data. Now create a function ast_retrieve_sorcery_by_module_name. By: George Joseph (gjoseph) 2014-02-05 11:13:22.563-0600 I created a patch for the sorcery side of this request. https://reviewboard.asterisk.org/r/3184/ Working on the dialplan side of this now. By: George Joseph (gjoseph) 2014-02-21 11:21:39.243-0600 Shouldn't have closed this one yet. Still some work to do. |