Summary:	ASTERISK-22411: British English Sound Packs
Reporter:	Jim Credland (jimcredland)	Labels:
Date Opened:	2013-08-27 05:27:06	Date Closed:	2014-03-04 15:30:42.000-0600
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Sounds
Versions:	SVN	Frequency of Occurrence
Related Issues:	is related to ASTERISK-22659 Make a new core and extra sounds release
Environment:	All	Attachments:	( 0) Jay_Benham_LICENSE_FOR_VOICE_PROMPT_FILESmarch2014.pdf
Description:	Jay Benham has been producing British English for Asterisk for a few years.  Here's a formal submission of the core and extra sounds for the official web-site. We will follow up with a scanned copy of the terms, signed by Jay.   I've verified the content against the latest version of the .txt files I could find. As the packs are quite big there are available here for download, or will be in about 15 minutes when they've finished copying! http://www.credland.net/asterisk/
Comments:	By: Jim Credland (jimcredland) 2013-08-28 10:38:47.037-0500 Attached, license. By: Rusty Newton (rnewton) 2013-09-16 16:54:18.179-0500 The attached PDF looks good. Over all it looks good, but there are a couple other issues. 1. It looks like you have left the Allison Smith plain text LICENSE files. From the instructions: https://wiki.asterisk.org/wiki/display/AST/Asterisk+Soundfiles+Submission+Process bq. Create a file called "LICENSE" and include the license text (listed below these instructions) which are the Creative Commons Attribution-ShareAlike v3 license terms. The LICENSE file for both tarballs will need to be replaced with your own. 2. A diff of the core sounds directory from trunk and your core tarball shows a few differences in files that exist or don't exist in one or the other directory: Only in core_GB/: dollars.wav Only in sounds-trunk/core/en/digits: billion.wav Looks like your dollars.wav should go in the {{/digits}} directory and your tarball is missing the {{billion.wav}} file. That is all the issues I found. Otherwise it looks great. It is a coincidence that you submitted this when we are adding new sound prompts to our supported core sounds directories due to a couple of other issues on the tracker. Along with fixing the issues mentioned above, we'll need Jay to record and include the three following sound prompts. * "Uppercase"  (uppercase.wav) * "Lowercase"  (lowercase.wav) * "Your message has been successfully forwarded." (vm-msgforwarded.wav) All of the files can go in the root directory of your tarball. Hit "Send Back" or "Enter Feedback" once you have updated the tarballs with the needed changes. Thanks in advance! The prompts sound excellent. By: Jim Credland (jimcredland) 2013-09-21 10:06:19.883-0500 Right - I've removed dollars.wav from the core-sounds-en.txt I'm checking against, and added billion to the digits folder.  Jay has recorded the three extra files and I've added those in as well.  Also, the LICENSE is now updated properly. Checks here look good. {noformat} -- Processing cfg/core-sounds-en.txt from folder ./public -- Description: [ Asterisk Core Sounds ] ** Complete -- Processing cfg/extra-sounds-en.txt from folder ./public -- Description: [ Asterisk Extra Sounds ] ** Complete {noformat} It would be helpful to have an online authoritative source for the correct core-sounds-en.txt file we can check against, as with these changes I'm now working with a completely independent edit of it ! I'm just doing conversions and tar file builds and they will be online http://www.credland.net/asterisk/ in about an hour. cheers, J. By: Jim Credland (jimcredland) 2013-09-21 10:06:45.261-0500 Files online in an hour for you. By: Rusty Newton (rnewton) 2013-09-27 14:14:46.182-0500 Thanks Jim! bq. It would be helpful to have an online authoritative source for the correct core-sounds-en.txt file we can check against, as with these changes I'm now working with a completely independent edit of it! I can look into that, for the moment the authoritative source is the file from the last release. By: Rusty Newton (rnewton) 2013-10-30 20:25:39.061-0500 British (en_GB) sounds released in core 1.4.25 and extra 1.4.14. They are up now: http://downloads.asterisk.org/pub/telephony/sounds/releases/ The next releases of Asterisk will pull the appropriate versions of the sound packs, and have menuselect options for the en_GB sounds. By: Rusty Newton (rnewton) 2013-11-25 14:12:30.069-0600 Reopening, as we need the license PDF to be resubmitted. I've E-mailed Jim and Jay. By: Rusty Newton (rnewton) 2013-12-06 09:49:31.471-0600 Not sure why this auto-closed By: Rusty Newton (rnewton) 2014-02-17 11:46:13.564-0600 Putting this back into waiting for feeback, since we are waiting on a redo of the license. By: Michelle Fleming (mpetrone) 2014-03-04 15:11:18.729-0600 Confirming the completed license was received, good to go from my perspective. By: Michelle Fleming (mpetrone) 2014-03-04 15:26:46.303-0600 License for the voice prompt files is attached. By: Rusty Newton (rnewton) 2014-03-04 15:27:56.509-0600 Cool, thanks all.