|Summary:||ASTERISK-21827: [patch] Add kick all capability to app_confbridge's CLI command 'kick'|
|Reporter:||Dorian Logan (dorianlogan)||Labels:|
|Date Opened:||2013-05-28 09:11:21||Date Closed:||2013-07-16 11:31:28|
|Environment:||All||Attachments:||( 0) kickall-patch_v2.diff|
( 1) kickall-patch.diff
|Description:||Add support to kick all users from an active confbridge.
I have the patch ready - I am just waiting for legal approval from Digium before submitting it.
|Comments:||By: Rusty Newton (rnewton) 2013-05-31 09:13:31.251-0500|
You have a valid license agreement now. You can go ahead and attach the patch (or re-attach if you tried already).
Hit 'Send Back' to let us know the issue is ready to be looked at again.
By: Dorian Logan (dorianlogan) 2013-06-07 06:54:19.368-0500
Brilliant - I will build the patch file
By: Dorian Logan (dorianlogan) 2013-06-10 09:06:55.819-0500
By: Dorian Logan (dorianlogan) 2013-06-12 05:03:36.551-0500
Patch file has been uploaded - please let me know if you need anything further from me.
By: Dorian Logan (dorianlogan) 2013-06-13 07:45:31.921-0500
Patch is attached
By: Rusty Newton (rnewton) 2013-06-14 13:33:33.928-0500
Thanks. It's set to Open now. You may want to bring it up on the [dev list|http://lists.digium.com/mailman/listinfo/asterisk-dev] to see if others wants to test.
By: Dorian Logan (dorianlogan) 2013-06-24 08:39:28.453-0500
Hi, I have tried the dev list - any other ideas in order to get things moving?
By: Matt Jordan (mjordan) 2013-06-24 09:08:33.202-0500
The only comment I have is not to use C++ style comments. That's pretty minor however.
You may want to check out the [Asterisk Coding Guidelines|https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines] for any other patches you write - typically, it's the first thing developers look at when reviewing patches.
By: Dorian Logan (dorianlogan) 2013-07-03 11:26:31.105-0500
I have updated the patch in line with Matt's comments - does the status need to change so I can resubmit the patch?
By: Dorian Logan (dorianlogan) 2013-07-08 09:12:59.513-0500
Okay - I have updated the comments - do you want me to resubmit the patch?
By: Dorian Logan (dorianlogan) 2013-07-08 09:13:46.278-0500
By: Rusty Newton (rnewton) 2013-07-09 17:47:59.158-0500
Just submit the patch with a _v2 prefix or something to differentiate it and we'll see it.
By: Dorian Logan (dorianlogan) 2013-07-15 04:05:41.850-0500
Comment style changed
By: Dorian Logan (dorianlogan) 2013-07-15 04:06:44.260-0500
Patch updated to use 'c' style comments
By: Dorian Logan (dorianlogan) 2013-07-16 11:31:28.679-0500
By: Dorian Logan (dorianlogan) 2013-08-08 04:18:43.534-0500
Hi - this has been closed in error - please can you re-open it.
By: Rusty Newton (rnewton) 2013-08-18 12:34:13.215-0500
@Dorian - your patch was committed to trunk, hence the Closed(Fixed) status. Why do you feel it was closed in error?
By: Dorian Logan (dorianlogan) 2013-08-27 06:30:51.705-0500
Brilliant - many thanks.