Summary:ASTERISK-21799: [patch] Dropouts/distortion in MixMonitor recording when recording RTP with ptime of 60ms
Reporter:Michael Walton (mike@farsouthnet.com)Labels:
Date Opened:2013-05-21 00:55:01Date Closed:2013-05-28 12:39:01
Versions:11.4.0 Frequency of
Environment:Ubuntu 10.04.4 LTSAttachments:( 0) slinfactory.c.ASTERISK-21799.patch
Description:When using MixMonitor to record a SIP call with ptime 60ms (possibly others also), the recording of one of the directions is heavily distorted due to repeated discontinuities in the recorded stream. Rate of dropout is 10-20 times per second.

The bug has been found in main/slinfactory.c and exists in at least 1.8 and 11 SVN revisions. The problem is a clear bug in the hold buffer logic in ast_slinfactory_read(). The attached patch fixes the problem by using the current offset sf->offset instead of the start of the hold buffer as the source for memcpy'ing data to the  read buffer.
Comments:By: Michael Walton (mike@farsouthnet.com) 2013-05-21 01:06:09.426-0500

I will submit the patch as soon as my License Agreement is processed.

By: Michael Walton (mike@farsouthnet.com) 2013-05-21 08:14:38.321-0500

Patch for Asterisk 11 main/slinfactory.c

By: Jonathan Rose (jrose) 2013-05-28 12:38:14.811-0500

Thanks for the patch. I tried it out and am in the process of committing it.  Good spot.