Summary:ASTERISK-21743: [patch] - Core show Locks, Include Asterisk version.
Reporter:Alec Davis (alecdavis)Labels:
Date Opened:2013-05-01 05:41:45Date Closed:2013-05-02 01:47:38
Versions:Frequency of
Environment:Attachments:( 0) core_held_lock_show_version.diff.txt
Description:Assist when reporting deadlocks, with the version.

=== Currently Held Locks ================ SVN-branch-11-r386878M
Comments:By: Jason Parker (jparker) 2013-05-01 09:54:14.697-0500

As trivial as this is, I do have one suggestion - put the version on its own new line.

By: Rusty Newton (rnewton) 2013-05-01 09:56:37.704-0500

Alec, this looks useful, but out of curiosity what debugging or troubleshooting scenarios is this useful for - where we wouldn't already know the Asterisk version?

By: Rusty Newton (rnewton) 2013-05-01 10:35:04.611-0500

Jason Parker made a good point "If there's a deadlock, it may not be possible to execute many CLI commands (core show version, for example)". But they should generally be able to execute "core show locks".

Although a reporter could check their Asterisk version in other ways, for a deadlock issue reporter this would possibly reduce the number steps they have to take when gathering information and provide additional confidence as to which version they are using.

By: Alec Davis (alecdavis) 2013-05-01 13:52:39.996-0500

ASTERISK-21657 was the idea for this, where the reporter may have got the version wrong.

By: Rusty Newton (rnewton) 2013-05-01 17:19:38.923-0500

@Alec Davis, thanks. I agree this should be useful.

By: Matt Jordan (mjordan) 2013-05-01 21:42:51.293-0500

Ship It!

(Although a separate line might be nice, e.g.,
== SVN-branch-11-...
== Currently Held Locks

By: Matt Jordan (mjordan) 2013-05-01 21:45:38.468-0500

Since this is a debugging aid, I'd be okay with this going into 1.8+ as well.