| Summary: | ASTERISK-21413: app_voicemail sound file for forwarding messages can be misleading | ||||
| Reporter: | Tom Petersen (netwrkr) | Labels: | |||
| Date Opened: | 2013-04-11 15:45:34 | Date Closed: | 2013-11-22 18:22:46.000-0600 | ||
| Priority: | Trivial | Regression? | |||
| Status: | Closed/Complete | Components: | Applications/app_voicemail | ||
| Versions: | 1.8.19.1 | Frequency of Occurrence | |||
| Related Issues: |
| ||||
| Environment: | Attachments: | ( 0) asterisk21413.patch ( 1) vm-msgforwarded.wav | |||
| Description: | When you forward a message (pressing 8, then 2 while in voicemail) you don't get an indication the message was in fact forwarded - instead what you hear is "your message has been saved" which makes one think something went wrong and the message was saved. | ||||
| Comments: | By: Michael L. Young (elguero) 2013-04-12 09:00:43.196-0500 Which sound file under the sounds directory should be played? By: Tom Petersen (netwrkr) 2013-04-12 12:40:03.787-0500 Hi Michael: I don't see any appropriate sound file. What I think should be played is something like "your message has been forwarded". By: Michael L. Young (elguero) 2013-04-12 12:49:45.403-0500 I couldn't find one either, hence why I asked in order to double check that I wasn't missing it somehow. So, what would be needed is a new sound file. The only information I could find on contributing sound files was this wiki page: https://wiki.asterisk.org/wiki/display/AST/Asterisk+Soundfiles+Submission+Process. By: Rusty Newton (rnewton) 2013-04-12 14:05:00.049-0500 So in most cases we don't accept improvement or feature requests without a patch. However in this case it's sort of a user experience improvement/bug and to improve it we have to request new sound files from the voice professionals that support the core supported languages. We'll also need the code change in app_voicemail to play the new file. We'll keep this issue open to track the inclusion of the new file into core sounds and the trivial code change to app_voicemail. I think I can handle all of that when I get a free moment. By: Tom Petersen (netwrkr) 2013-04-12 14:18:06.942-0500 Rusty: If you want to handle the patch, I'm happy to have Allison record the necessary sound file and give it away to the community as I have other work for her she can do at the same time. Thanks. By: Rusty Newton (rnewton) 2013-04-17 18:11:52.803-0500 Tom, that sounds great and would really be appreciated. As soon as you attach the raw 48kHz, 16-bit signed linear format sound file then I'll patch Asterisk with the appropriate file name. I'm thinking "vm-msgforwarded" You can indicate to Allison that the one prompt will be used in core Asterisk sounds, just in case she needs to know. I'd say that "Your message has been successfully forwarded." would be a good simple phrase for that file. By: Rusty Newton (rnewton) 2013-04-18 09:57:56.555-0500 I almost forgot! Since this is a core sound, we'll actually need it from all the languages supported in core sounds. That is French,Russian and Australian English (and Italian is coming soon) in addition to English. Not Spanish since we don't currently have a Spanish sounds maintainer. You can go ahead and work with Allison. I'll get the line "Your message has been successfully forwarded." translated and recorded in the other languages. By: Michael L. Young (elguero) 2013-04-18 11:27:06.598-0500 Rusty, What is involved in becoming a Spanish sounds maintainer? Does being a maintainer mean to record the sounds or is it to verify the sounds are correct? By: Rusty Newton (rnewton) 2013-04-18 13:35:20.934-0500 Must be a voice professional willing to record the entire set for that language and then as mentioned here: https://wiki.asterisk.org/wiki/display/AST/Asterisk+Soundfiles+Submission+Process "The artist who performed the original sounds must be available for additional work at a "reasonable" market price, and contact data must be provided with the sounds submission." It's fairly easy to find someone to translate and we have a community member who already translates for Spanish. Allison used to do the Spanish sounds, but she is unable to any longer. I'll probably put a request out on the lists soon to see if anyone knows a Spanish voice professional would be interested to donate their services. It's a bit of an advertisement for them. By: Michael L. Young (elguero) 2013-04-18 15:40:48.745-0500 I actually am fluent in Spanish myself, just an FYI. It would be great to get a native Spanish speaker for those sounds. The current sounds that we have, while very good because, well, it is done by the voice of Asterisk, they have a strong English speaker accent. I was curious to know so that I could mention it to some people that I know who do a lot of Spanish translation / interpreting work and see if they know of anyone who is a voice professional that would be interested. At the company where I work, we actually provide translation / interpreting services for different languages and Spanish is one of our main languages. Thanks for the info. By: Tom Petersen (netwrkr) 2013-04-22 16:00:12.838-0500 Rusty - I just uploaded the file from Allison. By: Rusty Newton (rnewton) 2013-09-13 09:08:52.698-0500 From the https://wiki.asterisk.org/wiki/display/AST/Asterisk+Soundfiles+Submission+Process bq. Soundfiles must be in ".wav" 48kHz 16-bit signed linear format - Digium will do all conversions to various codecs. Tom, looks like you uploaded the 8kHz version instead of the 48kHz. Can you upload the 48khz? We need that, as it will be transcoded and such to other formats during the release process. Thanks in advance! By: Rusty Newton (rnewton) 2013-10-03 20:05:34.650-0500 I was able to get the file from Alison. Thanks! By: Rusty Newton (rnewton) 2013-11-22 18:22:46.259-0600 Committed revision 403106 in Trunk By: Rusty Newton (rnewton) 2013-11-22 18:23:44.637-0600 The new prompt is also in the last 1.4.25 core release, in the languages: en,en_GB,fr,it | ||||