[Home]

Summary:ASTERISK-20981: Call-ID header generation to exclude colon
Reporter:Michał Mosiewicz (mrmimo)Labels:
Date Opened:2013-01-24 01:22:47.000-0600Date Closed:2013-02-14 09:17:08.000-0600
Priority:MajorRegression?
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:1.8.20.0 Frequency of
Occurrence
Related
Issues:
Environment:Does not matterAttachments:
Description:I'm not marking it as a bug, but it makes asterisk incompatible with some grandstream phones (probably older GXP series).

One of our customers said that call transfer not always works. We discovered this after analysing weeks of logs, that sometimes these phones generated improper Refer-to headers when transfering. In place there was :5060 in original Call-ID, apropriate Refer-To header had some trash in it. As in example:

Refer-To: <sip:167@192.168.11.1?Replaces=2df72a142b79b2cd4d8d88f629641474%40192.168.11.1%3:5060%3Bfrom-tag%3D4161c6a374b2b401%3Bto-tag%3Das5a98266b>


Original Call-ID had a form of 2df72a142b79b2cd4d8d88f629641474@192.168.11.1:5060


Notice additional %3 characters in Refer-To.

So - we applied the following patch that seem to resolve the issue. I call it an issue, as it is not a bug, but we know that at least Grandstream GXP 2000 series phones are affected, and there is no upgrade to resolve it. We also notified the producer, but without feedback. As far as we have customers having dozens of these phones, we decided to fix it at Asterisk not at the phone part.

I attach the patch as it may be useful for other grandstream owners. Changing Call-ID generation seems harmless to asterisk, but saves some old hardware.

[Edit by Rusty Newton - removed patch, as it must be submitted with a signed contributors agreement]
Comments:By: Rusty Newton (rnewton) 2013-01-27 17:11:27.006-0600

https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines#AsteriskIssueGuidelines-PatchandCodesubmission

Please read through the guidelines, and re-attach your patch as required.

The patch should be written against trunk since this isn't necessarily a bug.

By: Rusty Newton (rnewton) 2013-02-14 09:17:00.046-0600

Suspended due to lack of activity. Please request a bug marshal in #asterisk-bugs on the IRC network irc.freenode.net to reopen the issue should you have the additional information requested.  Further information can be found at http://www.asterisk.org/developers/bug-guidelines