|Summary:||ASTERISK-19935: Patch to make app_system check if a command failed to execute due to permission denied.|
|Reporter:||Denis Alberto Martinez (dmartinez)||Labels:|
|Date Opened:||2012-05-31 10:02:10||Date Closed:||2017-12-15 10:07:41.000-0600|
|Environment:||Asterisk-1.8, asterisk-10||Attachments:||( 0) app_system.c.patch_ASTERISK-19935|
|Description:||Hello Eng, |
I created a patch that improves the app_system. The attached patch should make this application to check if a command failed to execute due to permission denied.
The patch was made against Asterisk-svn-368031 (trunk).
|Comments:||By: Rusty Newton (rnewton) 2012-06-01 14:34:30.691-0500|
Denis, thanks for the patch. Do you want to post this in reviewboard? With review it may get implemented faster. https://wiki.asterisk.org/wiki/display/AST/Reviewboard+Usage You can contact firstname.lastname@example.org to get an account on reviewboard if you don't have one already.
By: Denis Alberto Martinez (dmartinez) 2012-06-04 09:19:39.115-0500
I hope that I did it right :)
By: Jonathan Rose (jrose) 2012-06-28 16:44:46.362-0500
Hey Denis, Tilghman and I looked over the review a bit. Going by his comments, it seems like the patch you've provided is somewhat specific to bash and won't work in other shells. The complexity associated with making it work in an acceptable fashion is somewhat higher than we anticipated, so we are punting on this until another sprint. If you want to fix up the patch though, it will remain on Reviewboard and you can continue to pursue this there or through the other usual channels (mailing lists, IRC). Of course since you are local you can just head to the second floor and we'll try to set a new direction on this.
By: Denis Alberto Martinez (dmartinez) 2012-07-24 16:19:12.556-0500
I'm not sure what else to do on this case. It seems that we have some movement on reviewboard. Do we need to keep this case open?
By: Corey Farrell (coreyfarrell) 2017-12-15 10:07:41.734-0600
From discussion on reviewboard it appears this patch will not be merged, func_shell provides the solution instead.