Summary:ASTERISK-19835: use webrtc iILBC code for codec_iLBC
Reporter:Tzafrir Cohen (tzafrir)Labels:
Date Opened:2012-05-03 12:59:49Date Closed:2012-07-24 13:57:42
Versions:SVN Frequency of
Environment:Attachments:( 0) 0001-Macro-AST_PKG_CONFIG_CHECK.patch
( 1) 0002-Allow-building-codec_ilbc-using-system-libilbc.patch
( 2) external_ilbc.diff
Description:The license of the RFC3951 iLBC codec implementation does not seem clear to me and therefore I'm not sure I can use it.

Google's implementation from webrtc.org is slightly different. Latly, however, someone has been working on adapting it for use with the interface provided by the RFC3951 implementation:


Below is an initial patch (PoC - only simple changes to codecs/codec_ilbc.c so far) to use that library.
Comments:By: Tzafrir Cohen (tzafrir) 2012-05-03 13:03:04.179-0500

PoC changes to codec_ilbc.c alone

By: Tzafrir Cohen (tzafrir) 2012-05-03 17:16:24.204-0500

The two patches, 0001-Macro-AST_PKG_CONFIG_CHECK.patch  and 0002-Allow-building-codec_ilbc-using-system-libilbc.patch include the suggested code. The first one is a helper autoconf macro, and the second one includes all the needed changes.

The macro AST_PKG_CONFIG_CHECK is similar to AST_EXT_LIB_CHECK, but simply uses pkg-config (PKG_CHECK_MODULES).

By: Matt Jordan (mjordan) 2012-06-04 08:16:43.120-0500

Tzafrir - do you want to post this to Review Board?

By: Kevin P. Fleming (kpfleming) 2012-07-24 13:57:42.765-0500

This has been committed.