Summary:ASTERISK-19109: [patch] "deaf" participant support in ConfBridge
Reporter:Timo Teräs (fabled)Labels:patch
Date Opened:2011-12-27 01:40:35.000-0600Date Closed:
Versions:10.0.0 13.18.4 Frequency of
Environment:Attachments:( 0) ASTERISK-19109.patch
( 1) confbridge-deaf.patch
( 2) confbridge-deaf-20140307.patch
Description:MeetMe has support for 'deaf' participants which never get audio data from the conference. This is a very useful feature.

I've started implementing this for ConfBridge, please see attached patch for initial implemetation implementing this feature for bridge_softmix, and adding the cli and manager commands, and a confbridge action for this.
Comments:By: Paul Belanger (pabelanger) 2011-12-27 15:35:45.034-0600

new features need to be submitted against trunk, that said you might also want to open post your patches to reviewboard.  This will help developers review it.

By: Ravindran (eternalravi) 2011-12-27 17:24:13.476-0600

Hello, I am not sure how the duplicate issue was resolved....

but i still get an error after adding weak_import 1 and weak_1

and i get this error .......

CKs-MacBook-Pro:asterisk-10.0.0 RavindranKrishnaMudaliar$ make
CC="cc" CXX="" LD="" AR="" RANLIB="" CFLAGS="" make C menuselect CONFIGURE_SILENT="-silent" makeopts
make[1]: `makeopts' is up to date.
[CC] chan_bridge.c -> chan_bridge.o
[LD] chan_bridge.o -> chan_bridge.so
ld: duplicate symbol dyld_stub_binding_helper in /usr/lib/bundle1.o and /usr/lib/bundle1.o for architecture x86_64
collect2: ld returned 1 exit status
make[1]: *** [chan_bridge.so] Error 1
make: *** [channels] Error 2

I added this in CONFIG_LDFLAGS=

but still i got the same error....what should i do

By: Timo Teräs (fabled) 2011-12-28 00:38:53.946-0600

It was against trunk, but the trunk checkout was accidentally a month old so it did not apply cleanly. I've fixed my trunk checkout (using git to track). The patch is now rebased, and sent to reviewboard.

By: Kevin P. Fleming (kpfleming) 2011-12-30 12:12:08.469-0600

MeetMe does *NOT* have support for 'deaf' participants, it has support for 'talk-only' participants (in addition to 'listen-only' and regular participants).

I object to any part of this feature being referred to as 'deaf', in any form.

By: Timo Teräs (fabled) 2011-12-30 14:36:01.578-0600

Functionality wise it is the same exact thing. I was not aware that 'deaf' would be a negative or objectionable word to use; for me as non-English speaker it felt like the obvious choice that would be analogous to 'mute'. IIRC, freeswitch uses this term; and I might have also got it from there.

I would be perfectly ok with 'talk-only' too. In that case it might not make sense to add the menu action there. Though, I would eventually still need the manager actions to toggle the talk-only/listen-only/listen-and-talk state.

Perhaps you could comment on reviewboard which terms in which places would be acceptable? As we would then need to rename all the manager actions (to verbs) etc.

By: Timo Teräs (fabled) 2014-03-07 05:15:40.875-0600

Rebased patch against trunk.

By: Timo Teräs (fabled) 2014-10-31 02:47:53.941-0500

Updated against Asterisk 13. (not fully tested)