Summary:	ASTERISK-18994: playback of file format without seeking is broken
Reporter:	Timo Teräs (fabled)	Labels:
Date Opened:	2011-12-08 08:22:43.000-0600	Date Closed:	2012-01-06 09:56:19.000-0600
Priority:	Blocker	Regression?	Yes
Status:	Closed/Complete	Components:	Core/FileFormatInterface
Versions:	10.0.0-rc2	Frequency of Occurrence	Constant
Related Issues:	must be completed before resolving ASTERISK-19040 Asterisk 1.8.9.0 Blockers must be completed before resolving ASTERISK-19041 Asterisk 10.1.0 Blockers must be completed before resolving ASTERISK-19128 Asterisk 1.8.10 Blockers must be completed before resolving ASTERISK-19129 Asterisk 10.2.0 Blockers must be merged before resolving ASTERISK-18995 Support for OGG/Speex file format is related to ASTERISK-12260 retrydial hangs up when using a silent soundfile as anouncement
Environment:		Attachments:	( 0) fix-file-seek.patch
Description:	main/file.c:ast_streamfile() does seeking unconditionally on files. This breaks file formats that do not support seeking. This is a regression and apparently broke in r158062 (fixing issue #12929). The file formats that do not support seeking are: OGG/Vorbis, G.723, G.726, G.729, H.263, H.264 and my upcoming OGG/Speex. Perhaps the core test should use ftell() to get old offset, do fseek() test, and use regular fseek() to resume where we where.
Comments:	By: Timo Teräs (fabled) 2011-12-09 03:37:15.351-0600 Suggested fix. By: Timo Teräs (fabled) 2011-12-15 00:57:53.702-0600 Looks like Mantis and JIRA IDs do not match. The bug I was referring is Mantis ID 12929 which appears to have been remapped as ASTERISK-12260 By: Kinsey Moore (kmoore) 2012-01-05 16:22:20.129-0600 Patch committed with a tweak.  Verified that the tweaked patch also corrected the problem.