Summary:ASTERISK-18956: autocreatepeer enhancement (add prefix option for safer peers)
Reporter:Andrew Kohlsmith (akohlsmith)Labels:
Date Opened:2011-12-01 16:48:06.000-0600Date Closed:2017-12-12 17:35:26.000-0600
Versions: Frequency of
Environment:Attachments:( 0) 0000-add-inceptor-remove-double-manager-event.patch
( 1) 0001-implement-autocreatepeer-prefix-option.patch
Description:autocreatepeer uses the 'from' field from the device trying to register as the sip peer name. This can be problematic if you do not have control over the device trying to register.

This patch adds an autocreatepeer=prefix option, and additionally an autocreateprefix string. The default prefix is "autopeer_". When an unknown device attempts to register with Aterisk and autocreatepeer=prefix is set, the peer name becomes the prefix + number. (e.g. "autopeer_0", "autopeer_1", etc.).

Additonally, the AMI event for peer registration has an additional field "Inceptor: Automatic" if the registration is due to the autocreatepeer function.

Finally, a double-register AMI event is removed. Current functionality emits two registration AMI events for every autocreated peer; the patch corrects that.
Comments:By: Leif Madsen (lmadsen) 2011-12-02 13:43:19.877-0600

Seems fine to me. You'll need to update sip.conf.sample, the CHANGES and UPDATE.txt files as well. Also you have a warning that starts with 'no' and would prefer it to be 'No' :).

By: Leif Madsen (lmadsen) 2011-12-02 13:43:58.753-0600

Additionally if this doesn't apply cleaning to trunk, you'll need to make sure you provide a patch that does, since this is a new feature. Thanks!

By: Corey Farrell (coreyfarrell) 2017-12-12 17:35:27.052-0600

Closing as we received no response to a patch review and the patch no longer applies to current versions of Asterisk.