[Home]

Summary:ASTERISK-18873: MEETME_RECORDINGFILE only read when realtime meetme conference is first loaded from the database
Reporter:Byron Clark (byronclark)Labels:
Date Opened:2011-11-15 13:43:02.000-0600Date Closed:2011-12-07 14:32:16.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_meetme
Versions:1.8.7.1 Frequency of
Occurrence		Constant
Related
Issues:
Environment:Attachments:( 0) ASTERISK-18873-1.patch
Description:The MEETME_RECORDINGFILE variable is only checked when the conference is first loaded from the database. Here's an example dialplan where that causes a problem. {{foo}} is defined in the realtime database without the recordingfile field set:
{code}
exten => 1000,1,MeetMeCount(foo,conferencemembers)
exten => 1000,n,Set(MEETME_RECORDINGFILE=/tmp/conf_1000)
exten => 1000,n,MeetMe(foo,Mr)
{code}

In this case the conference will not be recorded because {{find_conf_realtime()}} sets the recordingfilename field to {{""}} and {{conf_run}} only checks to see if the recordingfilename field is not NULL.
Comments:By: Byron Clark (byronclark) 2011-11-15 13:45:11.875-0600

[^ASTERISK-18873-1.patch] only sets the recordingfilename field after the database load if the field was actually defined in the database.
By: Byron Clark (byronclark) 2011-11-15 14:07:17.764-0600

The example dialplan is a very poor example because MeetMeCount never tries to find realtime conferences.

The real problem is when you use MeetMe without the 'r' flag and then use it with the 'r' flag for a later conference.
By: Jonathan Rose (jrose) 2011-12-07 13:44:58.759-0600

I tested your patch, and it works well enough for the recording_file... but the format was also a problem.

This seems like a perfectly fine approach to the problem, though I should note that we actually need to do this sort of thing with recordingformat as well.

This doesn't look like it needs to be applied to anything else though.  As far as I'm aware, those are the only two obvious values that can receive input from a channel variable that would be overwritten by the blank strings set in here.

I'll go ahead and commit this with the recordingformat change included as well.  Thanks for your contribution.