|Summary:||ASTERISK-18839: [patch] missing unlock in sip_send_mwi_to_peer causes deadlock|
|Reporter:||Michael L. Young (elguero)||Labels:|
|Date Opened:||2011-11-08 09:35:58.000-0600||Date Closed:||2011-11-08 12:32:15.000-0600|
|Versions:||SVN 10.0.0-beta2 10.0.0-rc1||Frequency of|
|Environment:||Attachments:||( 0) asterisk-18839-missing-lock-trunk.diff|
( 1) asterisk-18839-missing-lock-trunk-v2.diff
|Description:||When sip_send_mwi_to_peer tries to check a peer's mailbox to get the message count, if no mailbox is found it returns without unlocking the peer. This creates a deadlock.|
This was missed in commit r343635 for branch 10 and commit r343636 for trunk. These commits were part of fixing ASTERISK-18663.
|Comments:||By: Michael L. Young (elguero) 2011-11-08 09:38:50.394-0600|
The attached patch should hopefully resolve this issue.
By: Michael L. Young (elguero) 2011-11-08 09:48:01.341-0600
V2 is probably a better patch. It just moves the unlock up before the return.
By: David Vossel (dvossel) 2011-11-08 12:29:00.484-0600
Yep, that is a problem. Great catch.